Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Generic Pod Renderer to ecosystem #516

Merged
merged 1 commit into from
Jul 14, 2020
Merged

Add Generic Pod Renderer to ecosystem #516

merged 1 commit into from
Jul 14, 2020

Conversation

finanalyst
Copy link
Contributor

Distribution contains Pod::To::HTML, Pod::To::MarkDown, and a Graphical README.md generator from Pod in Module file. Generates TOC and Glossary and puts them in HTML. Customisable CSS and favicon.
Implements P<> format code (old Pod::To::HTML does not do this).
Pod::To::HTML in this distribution passes all old Pod::To::HTML tests
All output determined by customisable Templates (Mustache engine but this can be changed by subclassing)
Lots of Documentation on usage and subclassing.

  • I agree to the usage of the META file as listed here.

  • I have a license field listed in my META file that is one of https://spdx.org/licenses

    • My license is not one of those found on spdx.org but I do have a license field.
      In this case make sure you have a license URL listed under support. See this example.
    • I don't have a license field. Yes, I understand this is not recommended.

Distribution contains Pod::To::HTML, Pod::To::MarkDown, and a Graphical README.md generator from Pod in Module file. Generates TOC and Glossary and puts them in HTML. Customisable CSS and favicon.
Implements P<> format code (old Pod::To::HTML does not do this).
Pod::To::HTML in this distribution passes all old Pod::To::HTML tests
All output determined by customisable Templates (Mustache engine but this can be changed by subclassing)
Lots of Documentation on usage and subclassing.
Copy link
Contributor

@JJ JJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to qualify Pod::To::HTML with an auth clause, since there's already another Pod::To::HTML in the ecosystem. And, come to think of it, Pod::To::Markdown.

@finanalyst
Copy link
Contributor Author

Fixing

@JJ
Copy link
Contributor

JJ commented Jul 13, 2020 via email

@JJ
Copy link
Contributor

JJ commented Jul 14, 2020

OK, the problem here is that an upstream dependency, Template::Mustache, can't be installed because libCurl can't be instaled because gcc is not present in the container that does the test. We can let this pass and assume that all's good as long as that can be installed, or we can fix the container so that it gets libCurl (and other like that) to compile. Let me try that.

Copy link
Contributor

@JJ JJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, the problem is with NativeLibs. I've tested the new container and still the same error. So I'm gonna jump in here and approve this PR

@JJ JJ merged commit ccec92e into master Jul 14, 2020
@jubilatious1
Copy link

OK, the problem is with NativeLibs. I've tested the new container and still the same error. So I'm gonna jump in here and approve this PR

Does @salortiz somehow get notified?

https://github.com/salortiz/NativeLibs

@JJ
Copy link
Contributor

JJ commented Jul 14, 2020 via email

@finanalyst finanalyst deleted the finanalyst-patch-3 branch March 2, 2021 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants