Move all tests for streaming decoder to t/nqp #669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tests have been added in combination with a fix for the JVM backend (dbc1484). But it won't harm to run them on MoarVM, too.
The first one does not pass on the JVM backend, so it is skipped for now. But it should work on all backends, to it seems to be ok to move it to a common test file.
lizmat
approved these changes
Sep 25, 2020
Only because the API was initially only implemented in full on MoarVM. If it's being ported more thoroughly, then moving the test file makes sense (this just saved todo'ing stuff all over in the past). |
jnthn
approved these changes
Sep 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This proposal is related to #668: I plan to add more tests to the new test file t/nqp/116-streaming-decoder.t, and it feels clearer to have the tests in one common test file.
I might have missed a reason for having backend-specific test files (for the decoder tests). If so, it would be nice if someone could point that out to me.