Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test using fail in subset for custom message #175

Merged
merged 1 commit into from Oct 20, 2016

Conversation

zostay
Copy link
Contributor

@zostay zostay commented Oct 20, 2016

No description provided.

@zoffixznet
Copy link
Contributor

Would it be possible to change this test to check the actual content of the custom message is correct? The current dies-ok version takes the 1 is not even string as test description; not the content of the death to check against. For those purposes, there's throws-like:

throws-like { fail "foo" }, Exception, :message<foo>,
    'failure gave correct custom message';

@zostay
Copy link
Contributor Author

zostay commented Oct 20, 2016

Oh... duh... yeah, I'll fix it.

@zoffixznet
Copy link
Contributor

Also, you forgot to adjust the plan at the top of the file 😸

@zostay
Copy link
Contributor Author

zostay commented Oct 20, 2016

Fixed the plan and using throws-like now. Thx for the review.

@zoffixznet zoffixznet merged commit f06324c into Raku:master Oct 20, 2016
@zoffixznet
Copy link
Contributor

Thanks a lot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants