Added test for RT 131381 #273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Two quick things. You need to increment the plan count (https://github.com/danielcliffordmiller/roast/blob/d4aea7748a4e62e6ed218ab7f7e9bb87f561d005/S12-subset/subtypes.t#L7) by the number of added tests . Also, if the test fails, you need to fudge it with a todo on the like before the lives-ok (e.g., |
|
Thanks. I think there must be no space in the fudge tho, so it'd be: #?rakudo todo 'blah blah' |
zoffixznet
added a commit
that referenced
this pull request
Jun 1, 2017
|
@danielcliffordmiller BTW, add yourself to CREDITS: https://github.com/rakudo/rakudo/blob/nom/CREDITS Currently, you'll be listed in release announcement as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wrote a test for RT 131381 that currently fails.
https://rt.perl.org/Public/Bug/Display.html?id=131381