Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix external dependency #641

Merged
merged 1 commit into from May 10, 2020
Merged

Fix external dependency #641

merged 1 commit into from May 10, 2020

Conversation

JJ
Copy link
Contributor

@JJ JJ commented May 10, 2020

By putting it in here. Closes #640.

By putting it in here. Closes Raku#640.
@JJ JJ requested review from tbrowder and niner May 10, 2020 10:43
@tbrowder tbrowder merged commit 51f90e3 into Raku:master May 10, 2020
@tbrowder
Copy link
Member

Looks good to me. Thanks, @JJ!

@vrurg
Copy link
Contributor

vrurg commented May 11, 2020

Actually, considering https://github.com/Raku/roast/blob/master/packages/Test-Helpers/lib/Test/Util.pm6#L107 – what's the point? I highly recommend reverting this PR and re-implementing it with the standard routine.

@JJ
Copy link
Contributor Author

JJ commented May 11, 2020

OK, I'll do it adding to the other one, instead of reverting this commit.

@JJ
Copy link
Contributor Author

JJ commented May 11, 2020

The problem is that the signature is not exactly the same, not to mention the name:

Cannot resolve caller is_run(Str:D, Str:D, :compiler-args(Array), :exitcode(Int), :out(Str)); none of these signatures match:
    (Str $code, %expected, *%o)
    (Str $code, Str $input, %expected, *%o)
    (Str $code, %expected, Str $name, *%o)
    (Str $code, Str $input, %expected, Str $name, *%o)
  in block  at S26-documentation/block-leading-user-format.t line 56
  in block <unit> at S26-documentation/block-leading-user-format.t line 50

I can try and adapt the call to one of these signatures, or move the routine to that file. I'll see what can be done.

@JJ
Copy link
Contributor Author

JJ commented May 11, 2020

Also, is-run uses standard run while lexically Test::Utils' got its own run. So moving it there does not really work either. I don't think it's worth the while to reverse it, or even to move this is-run to Test::Helpers, but I'd be happy to hear other opinions.

@vrurg
Copy link
Contributor

vrurg commented May 11, 2020

I have committed a fix which makes use of roast is_run. The differences are rather subtle as except for different signature I never had a problem with is_run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Roast depends on Rakudo when it shouldn't
3 participants