Change the meaning of List ~~ List.new test #706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The smartmatch should return `False`. But the problem it supposed to test for, as stated in rakudo/rakudo#1833, is to make sure no warning is produced by the match. This job is still done well by the test.
First of all, intercept the warning and don't let them escape to keep TAP output clear. Also, make sure that the warnings produced are the ones we expect for.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The smartmatch should return
False. But the problem it supposed totest for, as stated in rakudo/rakudo#1833, is to make sure no warning is
produced by the match. This job is still done well by the test.
In support of rakudo/rakudo#4076