Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When setting custom stdin it should not attempt to reply back with a full string #34

Closed
AlexDaniel opened this issue Sep 22, 2016 · 2 comments
Closed

When setting custom stdin it should not attempt to reply back with a full string #34

AlexDaniel opened this issue Sep 22, 2016 · 2 comments
Labels
good first issue Low-hanging fruit (relatively easy issue, good for drive-by contributions) whateverable Issues affecting the bot framework (and therefore all of the bots)

Comments

@AlexDaniel
Copy link
Member

Take a look at this log:

<AlexDaniel> committable6: stdin http://websitetips.com/art​icles/copy/lorem/ipsum.txt
<committable6> AlexDaniel, Successfully fetched the code from the provided URL.
<committable6> AlexDaniel, https://gist.github.com/15e3​32d3fd7bb9c084b62cdbd2103fd0

It should not reply with a link to github. In this case it is probably enough if it just says “OK, custom STDIN is set” or something like that.
@AlexDaniel AlexDaniel added whateverable Issues affecting the bot framework (and therefore all of the bots) good first issue Low-hanging fruit (relatively easy issue, good for drive-by contributions) labels Sep 22, 2016
@AlexDaniel
Copy link
Member Author

Relevant piece of code: https://github.com/perl6/whateverable/blob/master/Whateverable.pm6#L61

@AlexDaniel AlexDaniel added the testneeded Issue is generally resolved but tests were not written yet label Jan 6, 2017
AlexDaniel added a commit that referenced this issue Mar 4, 2017
@AlexDaniel
Lots of refactoring and other code mangling
bbede98 
This commit introduces some functional changes and some minor code
style tweaks.

Issues resolved: #32 #34 #48 #49 #50 #67 #70 #88 #95 #102 #103 #105

Kids, do not try this at home. Try to work on each issue separately.

Funtions that were returnings lists of things are a leftover from the
old times. For now, these were changed to return hashes, but some time
later these may start returning an object of some class.

Subclassing a Str was an interesting idea to make filters
work. However, mixing in some roles is probably more appropriate (but
still a bit unusual).

｢help｣ method is now actually required because of a stub in Helpful
role.

*Many* other changes as well, but given that all this was done in one
go, it is hard to highlight everything that was changed.

I consider all code style changes not very important, but with a code
base that is using two styles randomly, I'd much rather like
everything to be consistent. Therefore, here is an incomplete list:
* Avoid parens when possible, unless parens add clarity
* Prefer no semicolon if not needed
* Prefer trailing commas
* Prefer no “return” (unless it adds clarity)
* Prefer unicode ops and quotes
* Try to fit into some reasonable line length (80, or at least 120)
* Prefer $msg over $message (it is too common in this project)
* Prefer ｢with｣ and ｢without｣ instead of ｢if defined｣
* Lines with ｢use …;｣ are sorted alphabetically
@AlexDaniel
Copy link
Member Author

Fixed in bbede98

AlexDaniel added a commit that referenced this issue Mar 12, 2017
@AlexDaniel
Make sure huge STDIN is not replied back fully
a96dec0 
Adds some tests for issue #34.

Interestingly, we only test stdin features for committable and
evalable even though *all* bots support it equally. Perhaps it's time
to create a separate file for common tests.
@AlexDaniel AlexDaniel removed the testneeded Issue is generally resolved but tests were not written yet label Mar 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Low-hanging fruit (relatively easy issue, good for drive-by contributions) whateverable Issues affecting the bot framework (and therefore all of the bots)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@AlexDaniel