-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unicodable should tell the number of results #88
Labels
unicodable
Issues related to Unicodable bot
Comments
AlexDaniel
added a commit
that referenced
this issue
Mar 4, 2017
This commit introduces some functional changes and some minor code style tweaks. Issues resolved: #32 #34 #48 #49 #50 #67 #70 #88 #95 #102 #103 #105 Kids, do not try this at home. Try to work on each issue separately. Funtions that were returnings lists of things are a leftover from the old times. For now, these were changed to return hashes, but some time later these may start returning an object of some class. Subclassing a Str was an interesting idea to make filters work. However, mixing in some roles is probably more appropriate (but still a bit unusual). 「help」 method is now actually required because of a stub in Helpful role. *Many* other changes as well, but given that all this was done in one go, it is hard to highlight everything that was changed. I consider all code style changes not very important, but with a code base that is using two styles randomly, I'd much rather like everything to be consistent. Therefore, here is an incomplete list: * Avoid parens when possible, unless parens add clarity * Prefer no semicolon if not needed * Prefer trailing commas * Prefer no “return” (unless it adds clarity) * Prefer unicode ops and quotes * Try to fit into some reasonable line length (80, or at least 120) * Prefer $msg over $message (it is too common in this project) * Prefer 「with」 and 「without」 instead of 「if defined」 * Lines with 「use …;」 are sorted alphabetically
Fixed in bbede98 |
AlexDaniel
added a commit
that referenced
this issue
Mar 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The text was updated successfully, but these errors were encountered: