Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update translation_ru.json #725

Merged
merged 6 commits into from Dec 14, 2020
Merged

Update translation_ru.json #725

merged 6 commits into from Dec 14, 2020

Conversation

onxblog
Copy link
Contributor

@onxblog onxblog commented Dec 1, 2020

Translated last ENG functions

Please try and fill out this template where possible, not all fields are required and can be removed.

  • Please check if the PR fulfills these requirements
  • [] The changes have been tested locally
  • [] There are no breaking changes
  • What kind of change does this PR introduce?
    (Bug fix, feature, docs update, ...)

  • What is the current behavior?
    (You can also link to an open issue here)

  • What is the new behavior (if this is a feature change)?

  • Other information:

Translated last ENG functions
"Power",
"Pulse W"
"Питание",
"удержать пит."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These two lines are supposed to be visible at the same time. I'm not sure what the second "пит." means but if it's the same word as "Питания" it'd be really odd IMHO.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not really sure about this function "Pulse W"
What is it really mean ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This allows to set the power (in Watts) of the short periodic pulse (it's short and rare enough to not heat the iron considerably but should be big enough to keep the power supply awake).

"Allow buttons",
"locking"
"Кнопки активны",
"заблокировать"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Three English words here form a sentence. Three Russian words seem to be uncoordinated, it's not a grammatically correct sentence AFAICT.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. I saw my mistakes.

],
"desc": "Sensitivity of the Hall effect sensor in detecting sleep <O=Off,L=Low,M=Medium,H=High>"
"desc": "Чувствительность датчика холла в режиме сна <O=Выкл,L=Низкий,M=Средний,H=Высокий>"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grammatical gender seems to be mixed up here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No it's all ok. For me.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Чувствительность" is a noun with a female grammatical gender. "Низкий/Средний/Высокий" are in male grammatical gender. I would expect them to match.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok I fix it

],
"desc": "When soldering, long press on both buttons lock them <D=Disable, B=Boost only, F=Full locking>"
"desc": "При работе, длинное нажатие обеих кнопок блокирует их <D=Отключено, B=Только турбо, F=Полная блокировка>"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra comma.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

Copy link
Contributor

@paulfertser paulfertser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello. I'm not the target audience of this translation but I have some familiarity with the language so hope my comments can be useful. That said, feel free to ignore them, I wouldn't mind.

@paulfertser
Copy link
Contributor

BTW, please do not forget to test the translation on the device to ensure all new menu lines fit the screen.

@Ralim
Copy link
Owner

Ralim commented Dec 13, 2020

Heya; where is this up to?
Is this in a mergable state? (I have zero ability to read this I'm afraid) 😢

@onxblog
Copy link
Contributor Author

onxblog commented Dec 14, 2020

Heya; where is this up to?
Is this in a mergable state? (I have zero ability to read this I'm afraid) 😢

Hi. Last update is correct with syntax and grammar and gender words.
Translation conveys the meaning 100%
If my translation is appropriate, you can merge it.

@Ralim Ralim merged commit e821e6c into Ralim:master Dec 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants