Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to OpenXR 1.0.12 #51

Merged
merged 1 commit into from
Oct 3, 2020
Merged

Update to OpenXR 1.0.12 #51

merged 1 commit into from
Oct 3, 2020

Conversation

Ralith
Copy link
Owner

@Ralith Ralith commented Oct 2, 2020

No description provided.

@Ralith
Copy link
Owner Author

Ralith commented Oct 2, 2020

@Jake-Shadle can you advise on whether we can come up with something safer than *mut c_void for the LoaderInitInfoAndroidKHR builder's parameters?

@Jake-Shadle
Copy link
Contributor

I don't know I'm not really familiar with the code in this repo or in the native openxr library, can it not be type aliased like the other c_void types? It could also be done as an opaque struct if it's just used as an opaque pointer from the native side.

@Ralith
Copy link
Owner Author

Ralith commented Oct 2, 2020

Upstream OpenXR just refers to them as void*, which is what this PR exposes in the -sys API. I'd like to also have safe high-level bindings, but I don't have any context for Android to know if that's possible. I'll probably just blacklist them from the high-level bindings for now.

@Jake-Shadle
Copy link
Contributor

That seems reasonable, if someone actually needs it it can always be added later. 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants