More Robust Null Terminator Handling #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Ralith this wasn't historically a problem (for me) but started in SteamVR beta |
Ralith
reviewed
Oct 10, 2020
openxr/src/lib.rs
Outdated
| // Strip null byte | ||
| bytes.truncate(bytes.len() - 1); | ||
| // Truncate at first null byte | ||
| let first_nt = bytes.iter().position(|&x| x == 0).expect("missing null"); |
There was a problem hiding this comment.
Suggested change
| let first_nt = bytes.iter().position(|&x| x == 0).expect("missing null"); | |
| let first_nt = bytes.iter().rposition(|&x| x != 0).expect("missing null") + 1; |
Makes more sense to search from the end.
In most recent SteamVR beta OpenXR calls can return values with multiple null terminators. This will cause the existing solution to remove only the final terminator. This commit adds a more robust check to truncate on the first occurrence of null terminator.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In most recent SteamVR beta OpenXR calls can return values with multiple
null terminators. This will cause the existing solution to remove only
the final terminator. This commit adds a more robust check to truncate
on the first occurrence of null terminator.
Closes #47