Fixing Import-Module for PS2 due to AppVeyor changes #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ter module to work on ps 2
|
Also I didn't have any option to squash commits during the merge and Pull Request, so you'll see all the commits I had... is this something that can be done on your end as the repo owner? |
|
Womp! I'm so sorry! Completely forgot about this PR, your workaround is much nicer! Closing this out for now - thanks for taking the time on this, and sorry again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves Issue #42
Although your code didn't change, it appears that the AppVeyor server may have changed.
The command "Import-Module Pester" no longer works for PowerShell 2 using AppVeyor service.
I just ran through your blog post about getting set up with PowerShell / Git / Pester / AppVeyor for CI/CD and was running into errors. Rather than give up on your post, I decided I would dig in and see if there is anything I could do to help. The quickest solution I came up with simply checks if you're running PS2 and if so, find the direct path to the pester module and import using the full path. This option looks for the latest version of the Pester module on the AppVeyor server before importing it, so it should be somewhat future-proof - depending on how the admin for AppVeyor has his server set up.
This is my first PR using public GitHub - but I figured this would help. If you don't accept the PR, could you at least make a note on your blog post or somewhere that your current code/method no longer works and maybe an option to fix it?
Thanks!