Separate XNATabControl text color for disabled / unselectable state #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rampastring
requested changes
Jan 4, 2020
XNAControls/XNATabControl.cs
Outdated
| return _textColorDisabled.Value; | ||
|
|
||
| return UISettings.ActiveSettings.DisabledItemColor; | ||
| } |
There was a problem hiding this comment.
Use the null-coalescing operator ?? to simplify the code: return _textColorDisabled ?? UISettings.ActiveSettings.DisabledItemColor;
While at it, you can make use of expression bodies to change the currently-7-line getter into the following nice and simple piece of code:
get => _textColorDisabled ?? UISettings.ActiveSettings.DisabledItemColor;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Self-explanatory. Makes XNATabControl text appear with different color if control is disabled or tab is unselectable. This disabled text color is customizable and defaults to the same color used by disabled buttons by default.