Fix account add crash #4244
Merged
Fix account add crash #4244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As reported in Ranchero-Software#3606, it was the case that attempting to add an account could result in a crash. This fixes the problem by retaining the `NSHostingController` that holds the `AddAccountsView` view in a manner similar to how 48138b1 retained `accountsAddLocalWindowController`.
|
NOTE: This is a resubmission of #3670 which was merged to main by @vincode-io on September 18th, 2022. Unfortunately, the previously merged commit is no longer in main. (Perhaps someone clobbered it with a force push?) I verified that this fix is still necessary and appropriate before resubmitting. Hopefully this will be included in the next update! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in #3606, it was the case that attempting to add an account could result in a crash. This fixes the problem by retaining the
NSHostingControllerthat holds theAddAccountsViewview in a manner similar to how 48138b1 retainedaccountsAddLocalWindowController.