-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Data Grid renderer does not show list output #149
Comments
@jmagosta could you please share your notebook? What type of notebook are you using and what is that list cell code? VSCode does use built-in renderers by default, and I documented the supported notebook cell output formats in extension docs already. I don't think your cell output is csv, json or any of the other supported data formats. See Features in docs for more info: https://github.com/RandomFractals/vscode-data-table#-features |
The notebook is trivial. It just a VSCode jupyter notebook -- the point is
that whatever the default renderer is that is used fails to show list
output. Honestly, except for the fact that Databricks VSCode requires this
extension I'm not sure what the point of it is.
…______________
John Mark Agosta
Palo Alto, CA
***@***.***
On Tue, Feb 28, 2023 at 2:36 PM Taras Novak ***@***.***> wrote:
@jmagosta <https://github.com/jmagosta> could you please share your
notebook?
What type of notebook are you using and what is that list cell code?
VSCode does use built-in renderers by default, and I documented the
supported notebook cell output formats in extension docs already.
I don't think your cell output is csv, json or any of the other supported
data formats.
—
Reply to this email directly, view it on GitHub
<#149 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAVKO3WYGQABOCAJBKGEQLWZZ4VDANCNFSM6AAAAAAVLJWS7E>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
the output is an array:
|
Yes, but it's not displayed.
…______________
John Mark Agosta
Palo Alto, CA
***@***.***
On Tue, Feb 28, 2023 at 4:22 PM Aaron Munger ***@***.***> wrote:
the output is an array:
"data": {
"text/plain": [
"[0, 1, 2, 3, 4]"
]
},
—
Reply to this email directly, view it on GitHub
<#149 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAVKO63GFZXDAJ6C2D4ZZ3WZ2JD3ANCNFSM6AAAAAAVLJWS7E>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
I was responding to @RandomFractals comment
Also, on this -
Merely installing this extension causes this blank output to show up, so the extension's renderer is prioritized over the built-in |
so the output of that command |
It is not true that "it will be displayed the same way as any other text "
A list, unlike a text string or tuple results in no display at all. This
is inconsistent. _J
…______________
John Mark Agosta
Palo Alto, CA
***@***.***
On Tue, Feb 28, 2023 at 11:46 PM Gerhard Brueckl ***@***.***> wrote:
so the output of that command list(range(5)) is a text/plain as already
mentioned by @amunger <https://github.com/amunger>
the data table renderers are mainly for displaying data frames/tables and
not for text outputs like in your example.
it will be displayed the same way as any other text e.g. "My random text"
Thats what Databricks returns, a text and not a table hence your text will
not be rendered properly as a list or table
if you were to use display(df) instead, it would output as text/x-json
and json/application which will then be rendered properly using the Table
Renderers
—
Reply to this email directly, view it on GitHub
<#149 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAVKO5ZCNJ6H52LOINWSULWZ35GDANCNFSM6AAAAAAVLJWS7E>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
@gbrueckl thanks for clarifying the way data table renderers work. @jmagosta you should use built-in or other renderers for your list. This extension is open source and you can actually see where and how cell output is handled and parsed in It would help if you actually included a simple notebook to reproduce your issue better. Your output screenshot doesn't even show the whole cell output rendering or anything about that list. |
A list, unlike a text string or tuple results in no display at all. Merely installing this extension causes this blank output to show up, because the extension's renderer is prioritized over the built-in. This is inconsistent, confusing behavior. |
This comment was marked as off-topic.
This comment was marked as off-topic.
the repro notebook is a single code cell. Running the cell with this extension installed will result in a blank output.
|
If one has switched to the grid renderer any list output is not displayed.
For instance:
This happened unexpectedly -- I don't recall loading this extension, or setting the display output to data grid. In any case returning no output for lists should not be a valid behavior.
The text was updated successfully, but these errors were encountered: