Little changes

RanolP · Dec 14, 2020 · 577a738 · 577a738
1 parent 359a610
commit 577a738
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 8 deletions.
diff --git a/.github/workflows/deployment.yml b/.github/workflows/deployment.yml
@@ -25,7 +25,7 @@ jobs:
         working-directory: ./generator
         run: npm run build:release
         env:
-          ARTIFACT_DOWNLOAD_TOKEN: ${{ secrets.ARTIFACT_DOWNLOAD_TOKEN }}
+          ARTIFACT_DOWNLOAD_TOKEN: ${{ secrets.REPO_ACCESS_TOKEN }}
 
       - name: Create Artifacts
         uses: actions/upload-artifact@v2
@@ -97,3 +97,8 @@ jobs:
           asset_path: ./dalmoori.zip
           asset_name: dalmoori-font.zip
           asset_content_type: application/zip
+      - name: Repository Dispatch
+        uses: peter-evans/repository-dispatch@v1
+        with:
+          token: ${{ secrets.REPO_ACCESS_TOKEN }}
+          event-type: update-page
diff --git a/generator/package.json b/generator/package.json
@@ -16,7 +16,7 @@
   "license": "MIT OR Apache-2.0",
   "devDependencies": {
     "@types/eslint": "^7.2.6",
-    "@types/node": "^14.14.12",
+    "@types/node": "^14.14.13",
     "@types/node-fetch": "^2.5.7",
     "@types/opentype.js": "^1.3.1",
     "@types/progress": "^2.0.3",
@@ -49,4 +49,4 @@
     "ttf2woff2": "^3.0.0",
     "unidata": "^13.0.0"
   }
-}
+}
diff --git a/generator/src/generate-advancement-report.ts b/generator/src/generate-advancement-report.ts
@@ -81,6 +81,9 @@ async function analyze(oldFont: Font, currentFont: Font): Promise<AnalysisResult
     const changed: Array<Codepoint | null> = await execute(
       function* () {
         for (const codepoint of fullCodepointsOf(block)) {
+          if (old.has(codepoint) || current.has(codepoint)) {
+            continue;
+          }
           const ch = String.fromCharCode(codepoint);
           const oldGlyph = oldFont.charToGlyph(ch);
           const currentGlyph = currentFont.charToGlyph(ch);

diff --git a/generator/src/util/opentype-paper.ts b/generator/src/util/opentype-paper.ts
@@ -43,17 +43,13 @@ function chooseProperSize(a: opentype.BoundingBox, b: opentype.BoundingBox): [wi
 
 export function makePathsForComparison(a: opentype.Glyph, b: opentype.Glyph): [paper.Path, paper.Path, paper.Project, [width: number, height: number]] {
   const size = chooseProperSize(a.getBoundingBox(), b.getBoundingBox());
-  const project = createProject(size[0], size[1]);
+  const project = createProject(...size);
   const aPaperPath = toPaperPath(a, project);
   const bPaperPath = toPaperPath(b, project);
   return [aPaperPath, bPaperPath, project, size];
 }
 
 export function toPaperPath(input: opentype.Glyph, project: paper.Project = createProject(...getSize(input.getBoundingBox()))): paper.Path {
-  if (project === undefined) {
-    const bb = input.getBoundingBox();
-    project = createProject(bb.x2 - bb.x1, bb.y2 - bb.y1);
-  }
   const output = new paper.Path({
     pathData: glyphToPath(input).toSVG(0),
     project,