Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

version 1.0 #93

Merged
merged 76 commits into from
Feb 19, 2014
Merged

version 1.0 #93

merged 76 commits into from
Feb 19, 2014

Conversation

daroczig
Copy link
Member

@daroczig daroczig commented Dec 1, 2013

rapport is pretty mature now and bunch of stuff have changes in the last 2+ years.
Let's clean up some stuff and release rapport 1.00 on the 6th of December.

@daroczig
Copy link
Member Author

daroczig commented Dec 1, 2013

This started with #90, but already touched at #65, #75 and bunch of other places. Be sure to read through all open tickets and resolve those that makes sense, and ditch the others at last.

@daroczig
Copy link
Member Author

daroczig commented Dec 2, 2013

Suggestions (pls copy the content of this comment into a new one later and update that as needed by e.g. ruling out a finished task):

  • ditch graphs.R
  • rename tpl\\.(.*) functions to rapport\\.$1 (with backward compatibility) in
    • export.R
    • template.R
    • tpl.path
    • rp.meta rp.body rp.info rp.inputs
    • tpl-check.R
  • don't deal with internal function names while renaming (I mean the gues... functions, but the ones found in template.R)
  • update docs and rapport.R
  • rename rp.outlier (stat_helpers.R) to something more meaningful and BTW what to do with these stat helpers? separate package? move those to the relevant templates?
  • same stands for stats_univar.R (maybe we should look for some companion package
  • same stands for tables.R
  • update/rename options
  • rp.data?
  • check reverse depends
  • maintainer?
  • merge template updates
  • move deadline to the end of the year

@aL3xa: pls let me know if you wanna deal with such stuff or I should take it over :)


Last updated: 28/12/2013

@daroczig
Copy link
Member Author

daroczig commented Jan 5, 2014

Yeah, it will fail until the new rapportools package is not pushed to CRAN.

daroczig added a commit that referenced this pull request Feb 19, 2014
version 1.0 with major renaming fun
@daroczig daroczig merged commit c735ab3 into master Feb 19, 2014
@daroczig
Copy link
Member Author

Okay, merging now. Will also soon push to CRAN after further decent testing.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 2803d76 on naming-conventions into * on master*.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants