Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement guild stickers #7126

Merged
merged 40 commits into from
Jul 31, 2021
Merged

implement guild stickers #7126

merged 40 commits into from
Jul 31, 2021

Conversation

NCPlayz
Copy link
Contributor

@NCPlayz NCPlayz commented Jun 29, 2021 •
edited

Summary

discord/discord-api-docs#3128

WIP. Would hugely appreciate testing this PR.

Basically implemented everything. Just need to squash any bugs and code review.

Done:

  • Client.fetch_sticker
  • Client.stickers
  • Client.get_sticker
  • Client.standard_sticker_packs (Name pending?)
  • StickerPack
  • Sticker Pack Banner Asset
  • Re-document StickerFormatType
  • Document StickerType
  • Document every other dataclass.
  • Redo overloads for Message.create
  • GuildSticker.delete
  • GuildSticker.guild

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

@jelni jelni mentioned this pull request Jul 7, 2021
Closed
3 tasks
@NCPlayz NCPlayz force-pushed the v2/sticker-stuff branch 2 times, most recently from a12553e to f1872f3 Compare July 17, 2021 21:27
@NCPlayz NCPlayz marked this pull request as ready for review July 20, 2021 23:16
oliver-ni
oliver-ni reviewed Jul 20, 2021
View reviewed changes
discord/abc.py Outdated Show resolved Hide resolved
discord/guild.py Outdated Show resolved Hide resolved
discord/http.py Show resolved Hide resolved
discord/sticker.py Outdated Show resolved Hide resolved
ToxicKidz
ToxicKidz suggested changes Jul 21, 2021
View reviewed changes
discord/client.py Outdated Show resolved Hide resolved
discord/client.py Outdated Show resolved Hide resolved
discord/client.py Show resolved Hide resolved
daggy1234
daggy1234 suggested changes Jul 21, 2021
View reviewed changes
Copy link
Contributor

@daggy1234 daggy1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These were just some docfixes I had noticed

discord/sticker.py Show resolved Hide resolved
discord/sticker.py Show resolved Hide resolved
@NCPlayz NCPlayz mentioned this pull request Jul 21, 2021
Closed
LostLuma
LostLuma reviewed Jul 21, 2021
View reviewed changes
discord/guild.py Outdated Show resolved Hide resolved
discord/client.py Outdated Show resolved Hide resolved
discord/guild.py Outdated Show resolved Hide resolved
discord/guild.py Outdated Show resolved Hide resolved
discord/guild.py Outdated Show resolved Hide resolved
discord/guild.py Outdated Show resolved Hide resolved
diceroll123
diceroll123 reviewed Jul 21, 2021
View reviewed changes
discord/client.py Outdated Show resolved Hide resolved
@ImVaskel ImVaskel mentioned this pull request Jul 23, 2021
Closed
Rapptz
Rapptz requested changes Jul 28, 2021
View reviewed changes
Copy link
Owner

@Rapptz Rapptz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is good.

I think type annotations should be used for all variable declarations within __init__ though since we're doing that going forward for meeting pyright's typed % metric. i.e.

def __init__(self, foo: int):
    self.foo: int = foo

even though it's repetitive

discord/guild.py Outdated Show resolved Hide resolved
discord/sticker.py Outdated Show resolved Hide resolved
@Rapptz Rapptz added this to In progress in v2.0 via automation Jul 28, 2021
NCPlayz and others added 19 commits July 29, 2021 13:47
@NCPlayz
use store_user again smh
0e51e38
@NCPlayz
move that back to TYPE_CHECKING smh
bb19072
@NCPlayz
fix send_files thanks @daggy1234
80592c1
@NCPlayz @ToxicKidz
Apply suggestions from code review
7b76055 
Co-authored-by: ToxicKidz <78174417+ToxicKidz@users.noreply.github.com>
@NCPlayz
add versionadded everywhere, fix typings as well :yert:
507e5e0
@NCPlayz
await
59d57d7
@NCPlayz
creator -> user properly
ce18a68
@NCPlayz
pt 2
517c126
@NCPlayz
oh i didn't notice this when i was resolving the merge conflict
3f8118a
@NCPlayz
daggy review
b795553
@NCPlayz
fix creating stickers thanks @MrKomodoDragon
d8d43ad
@NCPlayz
fix GuildSticker.edit to not require every argument
12e68ae
@NCPlayz
store sticker when created
24bdca5
@NCPlayz @diceroll123 @LostLuma
Apply suggestions from code review
d70be3b 
Co-authored-by: Steve C <diceroll123@gmail.com>
Co-authored-by: Lilly Rose Berner <lilly@lostluma.dev>
@NCPlayz
remove get_sticker since get_emoji doesn't exist :rooEZ:
aff8631
@NCPlayz
add stickers guild limit; guesstimate MORE_STICKERS for now
4371483
@NCPlayz
hmm
1d31bdd
@NCPlayz
make StickerPack.banner a property
6c6d1c3
@NCPlayz @Rapptz
Update discord/guild.py
4c90b1b 
Co-authored-by: Danny <Rapptz@users.noreply.github.com>
@Rapptz Rapptz merged commit 60d82cf into Rapptz:master Jul 31, 2021
v2.0 automation moved this from In progress to Done Jul 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diceroll123 diceroll123 diceroll123 left review comments

@oliver-ni oliver-ni oliver-ni left review comments

@LostLuma LostLuma LostLuma left review comments

@daggy1234 daggy1234 daggy1234 requested changes

@ToxicKidz ToxicKidz ToxicKidz requested changes

@Rapptz Rapptz Rapptz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
v2.0
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@NCPlayz @diceroll123 @Rapptz @oliver-ni @LostLuma @daggy1234 @ToxicKidz