Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document sticker packs, sticker routes, and guild stickers #3128

Merged
merged 26 commits into from Jul 19, 2021

Conversation

advaith1
Copy link
Contributor

@advaith1 advaith1 commented Jun 16, 2021

  • Moves sticker object to new page
  • Documents sticker.type
  • Documents the sticker pack object
  • Documents /stickers/:id, /sticker-packs, /guilds/:id/stickers, and /guilds/:id/stickers/:id
  • Documents Guild.stickers
  • Documents GUILD_STICKERS_UPDATE gateway event
  • Renames the MANAGE_EMOJIS permission and GUILD_EMOJIS intent
  • Documents sending sticker_ids
  • Documents sticker audit log stuff
  • Documents the Sticker and Sticker Pack Banner CDN endpoints

docs/Reference.md Show resolved Hide resolved
docs/resources/Sticker.md Show resolved Hide resolved
advaith1 and others added 2 commits June 16, 2021 00:34
Co-authored-by: Adrian Paschkowski <leiter04@gmail.com>
@advaith1 advaith1 changed the title Document sticker packs and sticker routes Document sticker packs, sticker routes, and guild stickers Jun 16, 2021
Copy link
Contributor

@jkcailteux jkcailteux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once comments are addressed

docs/resources/Sticker.md Outdated Show resolved Hide resolved
docs/resources/Sticker.md Outdated Show resolved Hide resolved
@topi314 topi314 mentioned this pull request Jul 1, 2021
@Lulalaby
Copy link
Contributor

Lulalaby commented Jul 1, 2021

@advaith1
Do you know the update, create & delete events?
Could you add them if they exist?

@Lulalaby
Copy link
Contributor

Lulalaby commented Jul 1, 2021

@advaith1
Do you know the update, create & delete events?
Could you add them if they exist?

found out

Sticker Create:

"stickers": [
  {
    "type": 2,
    "tags": "star_struck",
    "name": "Miku Dance",
    "id": "859934445338624001",
    "guild_id": "858089281214087179",
    "format_type": 2,
    "description": "Dancing cute miku",
    "available": true,
    "asset": ""
  },
  {
    "type": 2,
    "tags": "eyes",
    "name": "test",
    "id": "860194784416366612",
    "guild_id": "858089281214087179",
    "format_type": 1,
    "description": "test",
    "available": true,
    "asset": ""
  }
], "guild_id": "858089281214087179", "guild_hashes": {
  "version": 1,
  "roles": {
    "hash": "8WaWRHai7u0"
  },
  "metadata": {
    "hash": "DH7tLBn8PC4"
  },
  "channels": {
    "hash": "SI4E5jya9XI"
  }
}

Sticker Update:

"stickers": [
  {
    "type": 2,
    "tags": "star_struck",
    "name": "Miku Dance",
    "id": "859934445338624001",
    "guild_id": "858089281214087179",
    "format_type": 2,
    "description": "Dancing cute miku",
    "available": true,
    "asset": ""
  },
  {
    "type": 2,
    "tags": "eyes",
    "name": "Test Eyes",
    "id": "860194784416366612",
    "guild_id": "858089281214087179",
    "format_type": 1,
    "description": "test",
    "available": true,
    "asset": ""
  }
], "guild_id": "858089281214087179", "guild_hashes": {
  "version": 1,
  "roles": {
    "hash": "8WaWRHai7u0"
  },
  "metadata": {
    "hash": "7Gn3+AwV3zg"
  },
  "channels": {
    "hash": "SI4E5jya9XI"
  }
}

Sticker Delete:

"stickers": [
  {
    "type": 2,
    "tags": "star_struck",
    "name": "Miku Dance",
    "id": "859934445338624001",
    "guild_id": "858089281214087179",
    "format_type": 2,
    "description": "Dancing cute miku",
    "available": true,
    "asset": ""
  }
], "guild_id": "858089281214087179", "guild_hashes": {
  "version": 1,
  "roles": {
    "hash": "8WaWRHai7u0"
  },
  "metadata": {
    "hash": "7Gn3+AwV3zg"
  },
  "channels": {
    "hash": "SI4E5jya9XI"
  }
}

It's all fired as update event

@drklee3
Copy link

drklee3 commented Jul 1, 2021

Gatway intent for sticker events are also added to the GUILD_EMOJIS intent so that should also be changed to include stickers.

@ghost
Copy link

ghost commented Jul 1, 2021

Can this document the sticker cdn endpoint?
stickers/sticker_id.png

@advaith1
Copy link
Contributor Author

advaith1 commented Jul 2, 2021

ok I think I've documented everything!

* except the sticker cdn endpoint; not sure if staff want that documented

@Lulalaby
Copy link
Contributor

Lulalaby commented Jul 2, 2021

ok I think I've documented everything!

  • except the sticker cdn endpoint; not sure if staff want that documented

thank you ❤️

@advaith1 advaith1 requested a review from jkcailteux July 19, 2021 21:35
Copy link
Contributor

@Lulalaby Lulalaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great so far

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants