-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
App Premium implementation #9453
Conversation
Took 5 minutes
Implement SKUType and EntitlementType enums
…actually mean and represent
# Conflicts: # discord/sku.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Updated fields from following PR: Premium Apps: SKU and Entitlement fields discord/discord-api-docs#6477
- Improvement suggestions
Co-authored-by: Andrin S. <65789180+Puncher1@users.noreply.github.com>
Document SKUFlags
Add missing import of annotations future in types/sku.py
I'd say we better wait for an official approval of this PR. |
That PR is by an employee. |
My bad. Missed the contributor tag. Then gonna add these changes. |
Co-authored-by: Andrin S. <65789180+Puncher1@users.noreply.github.com>
Remove consumed and add deleted instead
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor doc nits.
There's a bit of a gotcha with the design if someone decides to save Entitlement instances to a variable somewhere since those instances aren't ever updated with gateway information those instances will became stale. It's not an issue with this PR, but it's something to keep in mind.
Co-authored-by: Danny <1695103+Rapptz@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
Summary
This represent the implementation of App Subscriptions/App Premium.
I was already able to test the implementation, since I got invited to join the Beta. Based on my tests, everything should work flawlessly.
This PR may need improvements regarding util methods, which interconnect models and simplify the workflow with entitlements.
Checklist