Add note about archiver_id
#9852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rapptz
requested changes
May 30, 2024
discord/threads.py
Outdated
Comment on lines
125
to
127
| .. note:: | ||
| This field has been removed from the :ddocs:`Thread Metadata Object <resources/channel#thread-metadata-object>`. | ||
| The ``archiver_id``, therefore, will always be ``None`` and can only be obtained via the audit log now. |
There was a problem hiding this comment.
Suggested change
| .. note:: | |
| This field has been removed from the :ddocs:`Thread Metadata Object <resources/channel#thread-metadata-object>`. | |
| The ``archiver_id``, therefore, will always be ``None`` and can only be obtained via the audit log now. | |
| .. note:: | |
| Due to an API change, the ``archiver_id``, therefore, will always be ``None`` and can only be obtained via the audit log now. |
Simplify the wording.
There was a problem hiding this comment.
Simplified it. But also removed the "therefore" because it at least to me didn't make sense in the new sentence structure
Rapptz
reviewed
May 30, 2024
Co-authored-by: Danny <1695103+Rapptz@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Discord removed the
archiver_idfield from their thread metadata.See following discussion thread and api docs commit:
#9850
discord/discord-api-docs@82c98ba
This pull request adds a note explaining that the value will always be
Noneand that the id can only be acquired via the audit log nowChecklist