Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate quick replies in favor of using custom #5239

Closed
erohmensing opened this issue Feb 13, 2020 · 8 comments
Closed

deprecate quick replies in favor of using custom #5239

erohmensing opened this issue Feb 13, 2020 · 8 comments
Labels
area:rasa-oss/channels 📞 Issues focused around rasas input and output channels area:rasa-oss 🎡 Anything related to the open source Rasa framework area:rasa-oss/training-data Issues focused around Rasa training data (stories, NLU, domain, etc.) type:maintenance 🔧 Improvements to tooling, testing, deployments, infrastructure, code style.

Comments

@erohmensing
Copy link
Contributor

erohmensing commented Feb 13, 2020

Description of Problem: We currently support quick_replies in the domain file, though they are only supported on the facebook channel. This leads to a lot of extra code for something that is a pretty specific use case. I thought about this after reconsidering adding them to the SDK, where the support for them never made it in.

Overview of the Solution: Now that the same functionality can be accomplished via the custom domain key, we can handle facebook quick replies the way that any other channel-specific UI elements are handled.

@erohmensing erohmensing added type:maintenance 🔧 Improvements to tooling, testing, deployments, infrastructure, code style. area:rasa-oss 🎡 Anything related to the open source Rasa framework labels Feb 13, 2020
@erohmensing
Copy link
Contributor Author

@tmbo what are your thoughts on this?

@stale
Copy link

stale bot commented May 27, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label May 27, 2020
@erohmensing
Copy link
Contributor Author

Thinking we should do this for elements as well. We can provide examples of how to use channel-specific features in the channel's documentation if we want -- similar to #5693 but showing how to implement that stuff in custom

@stale stale bot removed the stale label May 28, 2020
@erohmensing erohmensing added this to the Rasa 2.0 Ideas milestone May 28, 2020
@erohmensing
Copy link
Contributor Author

erohmensing commented Aug 11, 2020

Current facebook quick reply format:

utter_something:
  - text: "hi!"
    quick_replies:
    - title: "button 1"
      payload: "/payload1"
    - title: "button 2
      payload: "/payload2"

with custom:

utter_something:
  - custom: 
      text: "hi!"
      quick_replies:
        - content_type: "text"
          title: "button 1"
          payload: "/payload1"
        - content_type: "text"
          title: "button 2
          payload: "/payload2"

It's a little more work, but you can also add images to your buttons, as well of tons of other quick reply content types like location, emails, and phone numbers. I expect some people are already using custom to achieve this functionality.
https://developers.facebook.com/docs/messenger-platform/send-messages/quick-replies/

@stale
Copy link

stale bot commented Nov 16, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Nov 16, 2020
@tmbo tmbo added area:rasa-oss/channels 📞 Issues focused around rasas input and output channels and removed area:rasa-oss 🎡 Anything related to the open source Rasa framework labels Nov 17, 2020
@stale stale bot removed the stale label Nov 17, 2020
@susajsnair
Copy link

susajsnair commented Nov 26, 2020

@erohmensing
Key 'quick_replies' was not defined

when i try to do

utter_something:
  - text: "hi!"
    quick_replies:
    - title: "button 1"
      payload: "/payload1"
    - title: "button 2
      payload: "/payload2"

@alwx alwx added area:rasa-oss 🎡 Anything related to the open source Rasa framework area:rasa-oss/training-data Issues focused around Rasa training data (stories, NLU, domain, etc.) labels Jan 28, 2021
@stale
Copy link

stale bot commented Jul 21, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jul 21, 2021
@rasabot-exalate rasabot-exalate added area:rasa-oss/channels_📞 and removed type:maintenance 🔧 Improvements to tooling, testing, deployments, infrastructure, code style. area:rasa-oss/channels 📞 Issues focused around rasas input and output channels labels Mar 17, 2022 — with Exalate Issue Sync
@stale stale bot removed the stale label Mar 17, 2022
@m-vdb m-vdb added area:rasa-oss/channels 📞 Issues focused around rasas input and output channels and removed area:rasa-oss/channels_📞 labels Mar 17, 2022
@rasabot-exalate rasabot-exalate added stale type:maintenance 🔧 Improvements to tooling, testing, deployments, infrastructure, code style. and removed type:maintenance_:wrench: labels Mar 17, 2022 — with Exalate Issue Sync
@stale stale bot removed the stale label Mar 21, 2022
@sync-by-unito
Copy link

sync-by-unito bot commented Dec 19, 2022

➤ Maxime Verger commented:

💡 Heads up! We're moving issues to Jira: https://rasa-open-source.atlassian.net/browse/OSS.

From now on, this Jira board is the place where you can browse (without an account) and create issues (you'll need a free Jira account for that). This GitHub issue has already been migrated to Jira and will be closed on January 9th, 2023. Do not forget to subscribe to the corresponding Jira issue!

➡️ More information in the forum: https://forum.rasa.com/t/migration-of-rasa-oss-issues-to-jira/56569.

@m-vdb m-vdb closed this as completed Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:rasa-oss/channels 📞 Issues focused around rasas input and output channels area:rasa-oss 🎡 Anything related to the open source Rasa framework area:rasa-oss/training-data Issues focused around Rasa training data (stories, NLU, domain, etc.) type:maintenance 🔧 Improvements to tooling, testing, deployments, infrastructure, code style.
Projects
None yet
Development

No branches or pull requests

6 participants