Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NER: all confidences per Token with DIETClassifier #7299

Closed
Novaal opened this issue Nov 17, 2020 · 4 comments
Closed

NER: all confidences per Token with DIETClassifier #7299

Novaal opened this issue Nov 17, 2020 · 4 comments
Labels
area:rasa-oss 🎡 Anything related to the open source Rasa framework area:rasa-oss/ml/nlu-components Issues focused around rasa's NLU components area:rasa-oss/ml 👁 All issues related to machine learning type:maintenance 🔧 Improvements to tooling, testing, deployments, infrastructure, code style.

Comments

@Novaal
Copy link

Novaal commented Nov 17, 2020

Description of Problem: Thanks for introducing the confidences for NER with #6038. Currently only the labels for the best matching entity is given. I would like to have an option to get all confidences including the confidences for labels with NO_ENTITY_TAG on a per token basis. This would allow me for example to choose the second best entity for specific tokens.

Overview of the Solution:

Change _predict_entities() to return a list of confidences on a per Token basis.

Examples (if relevant):

It could be an similar aproach like in _predict_label()

@Novaal Novaal added area:rasa-oss 🎡 Anything related to the open source Rasa framework type:enhancement ✨ Additions of new features or changes to existing ones, should be doable in a single PR labels Nov 17, 2020
@sara-tagger
Copy link
Collaborator

sara-tagger commented Nov 18, 2020

Exalate commented:

sara-tagger commented:

Thanks for submitting this feature request

🚀
@erohmensing will get back to you about it soon!


@Novaal
Copy link
Author

Novaal commented Nov 18, 2020

Exalate commented:

Novaal commented:

It seems to be, that _predict_entities() is also inconsistent to _predict_label() in the way, that if i have multiple classifiers for intents+entities, the last classifier will overwrite the intents and intent_rankings, but will add the entities to the list of the previous classifiers. Then its not necessarily distinguishable anymore, which classifier provided, which entity.

entities = message.get(ENTITIES, []) + entities

@wochinge wochinge added area:rasa-oss/ml 👁 All issues related to machine learning area:rasa-oss/ml/nlu-components Issues focused around rasa's NLU components type:maintenance 🔧 Improvements to tooling, testing, deployments, infrastructure, code style. and removed type:enhancement ✨ Additions of new features or changes to existing ones, should be doable in a single PR labels Jan 27, 2021
@koernerfelicia koernerfelicia mentioned this issue Jan 28, 2021
3 tasks
@stale
Copy link

stale bot commented Jul 21, 2021

Exalate commented:

stale[bot] commented:

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jul 21, 2021
@rasabot-exalate rasabot-exalate added area:rasa-oss and removed type:maintenance 🔧 Improvements to tooling, testing, deployments, infrastructure, code style. area:rasa-oss 🎡 Anything related to the open source Rasa framework area:rasa-oss/ml 👁 All issues related to machine learning labels Mar 17, 2022 — with Exalate Issue Sync
@stale stale bot removed the stale label Mar 17, 2022
@rasabot-exalate rasabot-exalate added area:rasa-oss 🎡 Anything related to the open source Rasa framework stale type:maintenance_:wrench: and removed type:maintenance labels Mar 17, 2022 — with Exalate Issue Sync
@stale stale bot removed the stale label Mar 17, 2022
@rasabot-exalate rasabot-exalate added area:rasa-oss/ml 👁 All issues related to machine learning stale and removed area:rasa-oss/ml labels Mar 17, 2022 — with Exalate Issue Sync
@stale stale bot removed the stale label Mar 17, 2022
@rasabot-exalate rasabot-exalate added stale type:maintenance 🔧 Improvements to tooling, testing, deployments, infrastructure, code style. and removed type:maintenance_:wrench: labels Mar 21, 2022 — with Exalate Issue Sync
@stale stale bot removed the stale label Mar 21, 2022
@sync-by-unito
Copy link

sync-by-unito bot commented Dec 19, 2022

➤ Maxime Verger commented:

💡 Heads up! We're moving issues to Jira: https://rasa-open-source.atlassian.net/browse/OSS.

From now on, this Jira board is the place where you can browse (without an account) and create issues (you'll need a free Jira account for that). This GitHub issue has already been migrated to Jira and will be closed on January 9th, 2023. Do not forget to subscribe to the corresponding Jira issue!

➡️ More information in the forum: https://forum.rasa.com/t/migration-of-rasa-oss-issues-to-jira/56569.

@m-vdb m-vdb closed this as completed Jan 9, 2023
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:rasa-oss 🎡 Anything related to the open source Rasa framework area:rasa-oss/ml/nlu-components Issues focused around rasa's NLU components area:rasa-oss/ml 👁 All issues related to machine learning type:maintenance 🔧 Improvements to tooling, testing, deployments, infrastructure, code style.
Projects
None yet
Development

No branches or pull requests

5 participants