Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update towncrier command to new API #10929

Merged
merged 2 commits into from
Feb 22, 2022
Merged

update towncrier command to new API #10929

merged 2 commits into from
Feb 22, 2022

Conversation

m-vdb
Copy link
Collaborator

@m-vdb m-vdb commented Feb 22, 2022

Proposed changes:

  • Update release script to use towncrier API that changed in 21.9.0
  • Update changelog template to fix missing title issues

In order to test, you can run make generate-pending-changelog to see how this looks like now (no changes from before). To cleanup up your local directory after this, you can run make cleanup-generated-changelog

@m-vdb m-vdb requested review from tczekajlo and removed request for tczekajlo February 22, 2022 14:09
@m-vdb
Copy link
Collaborator Author

m-vdb commented Feb 22, 2022

actually there is still an issue, it's not displaying the version name anymore 🤔

{% endif %}{% endfor %}
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the template changed, I found the solution in this comment

@m-vdb m-vdb requested a review from tczekajlo February 22, 2022 14:25
Copy link

@andreoid andreoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@m-vdb m-vdb removed the request for review from tczekajlo February 22, 2022 14:50
@m-vdb m-vdb merged commit 006e182 into 3.0.x Feb 22, 2022
@m-vdb m-vdb deleted the fix-changelog-generation branch February 22, 2022 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants