Refactor tf algorithms #4218

Ghostvv · 2019-08-09T11:35:44Z

Proposed changes:

factor out common tf methods into tf_utils.py
Substitute LSTM with Transformer in Embedding Policy
contains Substitute LSTM with Transformer in Embedding Policy #4098
fixes https://github.com/RasaHQ/research/issues/34
fixes Update tensorflow to 1.14.x #4089

Status (please check what you already did):

made PR ready for code review
added some tests for the functionality
updated the documentation
updated the changelog
reformat files using black (please check Readme for instructions)

docs/migration-guide.rst

tmbo

added a couple more comments - reviewed the missing parts ✔️

docs/migration-guide.rst

setup.py

rasa/utils/train_utils.py

answered all the comments

tmbo

looks good 💯

rasa/constants.py

rasa/nlu/classifiers/embedding_intent_classifier.py

Co-Authored-By: Tom Bocklisch <tom@rasa.com>

Ghostvv added 30 commits July 5, 2019 16:41

copy files from nlu_lstm

0322eeb

Merge branch 'master' into core_transformer

4ab5bf6

remove trash

92d24f0

Merge branch 'master' into core_transformer

88711dd

refactor neg sampling, sim, acc and loss

a39e10c

refactor train

c631646

normilize confidence inside pred graph

e355baa

use pred_confidence in predict

fdb15f6

move normalization to embed helper

fe5a3ad

maybe fix continue_training

4cff3c0

fix extract attention

2b1843c

add types

d1fae48

Add method descriptions

3ae9b77

break long lines

1d28d63

make methods more generic, by using expand_dims instead of tf.newaxis

00604d5

add first version of stratified batching

f2b0c91

update batching

435611f

remove prints

0f48690

add random perturbation of labels

c6634be

add validation split

b917e37

black

717d6e0

Merge branch 'master' into core_transformer

81cdaaa

update changelog

7d30f55

update tests

dc27bfc

fix featurizer, add t2t requirements

2faf24a

fix featurizer, add t2t requirements

bcd3bff

add tfp for t2t to requirements

9342569

fix requirements

3c204b9

remove check tf, update setup.py

2cd22a8

remove unused variables

0c08967

Ghostvv added 2 commits August 19, 2019 11:03

merge master

90e6407

merge master

13d9b34

tmbo reviewed Aug 19, 2019

View reviewed changes

docs/migration-guide.rst Outdated Show resolved Hide resolved

tmbo requested changes Aug 19, 2019

View reviewed changes

Ghostvv and others added 8 commits August 20, 2019 15:23

remove setuptools

5cfdd52

Merge branch 'master' into refactor-tf

7bb14df

update min compat version number, update changelog

059a723

update migration guide

295fee0

rename labels to label_ids

e3d635f

fix method name, black

74685d1

refactor balance_session_data

be34d00

Merge branch 'master' into refactor-tf

c0da060

Ghostvv and others added 9 commits August 21, 2019 11:24

add docs about max_history in embed policy

7526c49

move tf config to train utils and load it in nlu embed also

8a07ca8

remove setuptools from requirements

fae5561

merge master

73bf1f8

add setuptools requirement

5a39b66

merge master

983985b

bump to latest t2t

ea9e46a

Merge branch 'master' into refactor-tf

68bd262

fix tf 1.14 double logging problem

2b70467

tmbo approved these changes Aug 23, 2019

View reviewed changes

rasa/constants.py Outdated Show resolved Hide resolved

rasa/nlu/classifiers/embedding_intent_classifier.py Outdated Show resolved Hide resolved

rasa/nlu/classifiers/embedding_intent_classifier.py Outdated Show resolved Hide resolved

Ghostvv and others added 5 commits August 23, 2019 17:39

Update rasa/constants.py

370e41a

Co-Authored-By: Tom Bocklisch <tom@rasa.com>

Update rasa/nlu/classifiers/embedding_intent_classifier.py

e9e97f1

Co-Authored-By: Tom Bocklisch <tom@rasa.com>

Update rasa/nlu/classifiers/embedding_intent_classifier.py

df52d77

Co-Authored-By: Tom Bocklisch <tom@rasa.com>

change version to 1.3.0a1

05a361d

Merge branch 'master' into refactor-tf

1b32b0a

Ghostvv merged commit 9a75a8b into master Aug 23, 2019

Ghostvv deleted the refactor-tf branch August 23, 2019 19:31

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refactor tf algorithms #4218

Refactor tf algorithms #4218

Ghostvv commented Aug 9, 2019 •

edited

Loading

tmbo left a comment

tmbo left a comment

Refactor tf algorithms #4218

Refactor tf algorithms #4218

Conversation

Ghostvv commented Aug 9, 2019 • edited Loading

tmbo left a comment

Choose a reason for hiding this comment

tmbo left a comment

Choose a reason for hiding this comment

Ghostvv commented Aug 9, 2019 •

edited

Loading