-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use temp directory to save models trained through API #4480
Conversation
@ricwo
I think we should remove the option to do so. |
This could be used to overwrite random files on the `rasa` server. Hence, it's a significant security risk and has to be removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great
By doing that we keep the option to skip the training in case there are no changes
@ricwo https://docs.python.org/3/library/tempfile.html#tempfile.gettempdir stays the same over multiple runs. It could only lead to problems, when running multiple rasa instances on one machine, but I think we can neglect that for now (the worst case is that a training is done although it could have been skipped). What do you mean? |
yes that sounds good, let's use that - alternatively we could introduce a boolean |
Yep, good idea! Will do the change tomorrow to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great 🚀 Thanks for making this backwards-compatible
Co-Authored-By: ricwo <ric.wkr@gmail.com>
Co-Authored-By: ricwo <ric.wkr@gmail.com>
Proposed changes:
POST /model/train
now get saved in a temporary directory bydefault (instead of the
models
directory)Status (please check what you already did):
black
(please check Readme for instructions)