Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make slow_callback_duration a parameter in asyncio debugging #4511

Merged
merged 3 commits into from
Sep 25, 2019

Conversation

imLew
Copy link
Contributor

@imLew imLew commented Sep 23, 2019

Proposed changes:

  • Add the parameter slow_callback_duration to the utils function enable_async_loop_debugging and change its default value to 100ms, up from 1ms.
    Any asyncio calls that take longer than slow_callback_duration produce a warning. (There were lots of warnings)
    That was also the reason agent.load_model_from_server called set_log_level, since this is no longer necessary the call has been removed (it caused some other troubles).

enable_async_loop_debugging is called in tests and if rasa is run with --debug. A default value of 100ms might not always be appropriate and we might have to change it in some places for #4356

Status (please check what you already did):

  • made PR ready for code review
  • added some tests for the functionality
  • updated the documentation
  • updated the changelog
  • reformat files using black (please check Readme for instructions)

@imLew imLew changed the base branch from master to 1.3.x September 23, 2019 15:34
@imLew imLew merged commit 7456dc3 into 1.3.x Sep 25, 2019
@imLew imLew deleted the asyncio-callback-duration branch September 25, 2019 09:38
@imLew imLew mentioned this pull request Oct 1, 2019
4 tasks
@ricwo ricwo mentioned this pull request Oct 10, 2019
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants