RabbitMQ TLS Auth 1.3.x #4578
Merged
RabbitMQ TLS Auth 1.3.x #4578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Tobias Wochinger <t.wochinger@rasa.com>
RabbitMQ TLS auth
Co-Authored-By: ricwo <ric.wkr@gmail.com>
add missing ca_file arg to ssl_context
akelad
approved these changes
Oct 10, 2019
| @@ -91,9 +99,6 @@ Changed | |||
| (default behavior) or in a temporary directory by specifying the | |||
| ``save_to_default_model_directory`` field in the training request. | |||
|
|
|||
| [1.3.4] | |||
There was a problem hiding this comment.
what's this about? there's two fixed sections now for 1.3.4... also how was this even passing the build?!
There was a problem hiding this comment.
This was introduced with 1.3.7, so I'd assume the "fixed" below belongs into 1.3.7 - will move it there
There was a problem hiding this comment.
actually judging from #4511, it should just be part of 1.3.4 - not sure why it didn't end up in the right section
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes:
Status (please check what you already did):
black(please check Readme for instructions)