Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

let failsafe tracker store set wrapped tracker store domain #4832

Merged
merged 4 commits into from Nov 26, 2019
Merged

let failsafe tracker store set wrapped tracker store domain #4832

merged 4 commits into from Nov 26, 2019

Conversation

erohmensing
Copy link
Contributor

Proposed changes:

  • fix issue where slots in the domain are lost in local rasa x mode
  • when the failsafe tracker store's domain is updated, update the wrapped tracker store's domain

Still needs a changelog entry

Status (please check what you already did):

  • made PR ready for code review
  • added some tests for the functionality
  • updated the documentation
  • updated the changelog
  • reformat files using black (please check Readme for instructions)

wochinge
wochinge approved these changes Nov 25, 2019
View reviewed changes
Copy link
Contributor

@wochinge wochinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix!

@wochinge wochinge merged commit d40b736 into master Nov 26, 2019
@wochinge wochinge deleted the fallback-domain branch November 26, 2019 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wochinge wochinge wochinge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@erohmensing @wochinge @federicotdn