Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

let failsafe tracker store set wrapped tracker store domain #4832

Merged
merged 4 commits into from
Nov 26, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
15 changes: 13 additions & 2 deletions rasa/core/tracker_store.py
Original file line number Diff line number Diff line change
Expand Up @@ -785,12 +785,23 @@ def __init__(
in the primary tracker store.
"""

super().__init__(tracker_store.domain, tracker_store.event_broker)

self._fallback_tracker_store: Optional[TrackerStore] = fallback_tracker_store
self._tracker_store = tracker_store
self._on_tracker_store_error = on_tracker_store_error

super().__init__(tracker_store.domain, tracker_store.event_broker)

@property
def domain(self) -> Optional[Domain]:
return self._tracker_store.domain

@domain.setter
def domain(self, domain: Optional[Domain]) -> None:
self._tracker_store.domain = domain

if self._fallback_tracker_store:
self._fallback_tracker_store.domain = domain

@property
def fallback_tracker_store(self) -> TrackerStore:
if not self._fallback_tracker_store:
Expand Down
11 changes: 11 additions & 0 deletions tests/core/test_tracker_stores.py
Original file line number Diff line number Diff line change
Expand Up @@ -368,3 +368,14 @@ def test_fail_safe_tracker_store_with_retrieve_error():

assert tracker_store.retrieve("sender_id") is None
on_error_callback.assert_called_once()


def test_set_fail_safe_tracker_store_domain(default_domain: Domain):
tracker_store = InMemoryTrackerStore(domain)
fallback_tracker_store = InMemoryTrackerStore(None)
failsafe_store = FailSafeTrackerStore(tracker_store, None, fallback_tracker_store)

failsafe_store.domain = default_domain
assert failsafe_store.domain is default_domain
assert tracker_store.domain is failsafe_store.domain
assert fallback_tracker_store.domain is failsafe_store.domain