Skip to content
This repository has been archived by the owner on Aug 22, 2019. It is now read-only.

Paper eval scripts #550

Merged
merged 97 commits into from
Nov 9, 2018
Merged

Paper eval scripts #550

merged 97 commits into from
Nov 9, 2018

Conversation

akelad
Copy link
Contributor

@akelad akelad commented May 29, 2018

Proposed changes:

Status (please check what you already did):

  • made PR ready for code review
  • added some tests for the functionality
  • updated the documentation
  • updated the changelog

@akelad akelad changed the title [WIP] Paper eval scripts Paper eval scripts May 29, 2018
@amn41
Copy link
Contributor

amn41 commented Jun 13, 2018

@akelad what's the status on this? I guess we should give the scripts more descriptive names than train_paper , evaluate_paper as well

@akelad
Copy link
Contributor Author

akelad commented Jun 13, 2018

@amn41 The status is it's ready for review. But the embedding policy needs to be merged first. And yeah I agree about the names, couldn't come up with anything useful though 😛 any suggestions?

@m90
Copy link
Contributor

m90 commented Sep 4, 2018

This seems to be already mentioned in the "Evaluating and Testing" docs, but is not available with the lastest version on pypi / master. Will this land anytime soon or should the section be removed from the docs?

Copy link
Member

@tmbo tmbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple suggestions here and there but all in all it looks good 👍

rasa_core/policies/keras_policy.py Outdated Show resolved Hide resolved
rasa_core/policies/keras_policy.py Outdated Show resolved Hide resolved
rasa_core/evaluate.py Outdated Show resolved Hide resolved
rasa_core/evaluate.py Show resolved Hide resolved
rasa_core/evaluate.py Outdated Show resolved Hide resolved
rasa_core/train.py Show resolved Hide resolved
rasa_core/train.py Outdated Show resolved Hide resolved
rasa_core/train.py Show resolved Hide resolved
rasa_core/train.py Outdated Show resolved Hide resolved
rasa_core/train.py Outdated Show resolved Hide resolved
tmbo and others added 16 commits November 9, 2018 17:43
Co-Authored-By: akelad <32450038+akelad@users.noreply.github.com>
Co-Authored-By: akelad <32450038+akelad@users.noreply.github.com>
Co-Authored-By: akelad <32450038+akelad@users.noreply.github.com>
Co-Authored-By: akelad <32450038+akelad@users.noreply.github.com>
Co-Authored-By: akelad <32450038+akelad@users.noreply.github.com>
Co-Authored-By: akelad <32450038+akelad@users.noreply.github.com>
Co-Authored-By: akelad <32450038+akelad@users.noreply.github.com>
@akelad akelad merged commit cba85be into master Nov 9, 2018
@akelad akelad deleted the eval_scripts branch November 9, 2018 19:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
5 participants