This repository has been archived by the owner on Aug 22, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1k
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
@akelad what's the status on this? I guess we should give the scripts more descriptive names than |
@amn41 The status is it's ready for review. But the embedding policy needs to be merged first. And yeah I agree about the names, couldn't come up with anything useful though 😛 any suggestions? |
This seems to be already mentioned in the "Evaluating and Testing" docs, but is not available with the lastest version on pypi / master. Will this land anytime soon or should the section be removed from the docs? |
…to eval_scripts
tmbo
approved these changes
Nov 9, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple suggestions here and there but all in all it looks good 👍
Co-Authored-By: akelad <32450038+akelad@users.noreply.github.com>
Co-Authored-By: akelad <32450038+akelad@users.noreply.github.com>
Co-Authored-By: akelad <32450038+akelad@users.noreply.github.com>
Co-Authored-By: akelad <32450038+akelad@users.noreply.github.com>
Co-Authored-By: akelad <32450038+akelad@users.noreply.github.com>
Co-Authored-By: akelad <32450038+akelad@users.noreply.github.com>
Co-Authored-By: akelad <32450038+akelad@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes:
Status (please check what you already did):