Skip to content

Commit

Permalink
Local development tweaks (#736)
Browse files Browse the repository at this point in the history
Just a couple of small tweaks to make local development easier:

* `disableHostCheck` facilitates using the `rpfdev.com` domain I'm
working on (I'll share more details of this once its ready for use!)
* adding shared network facilitates a local nginx proxy
* changing port avoids a clash with projects-ui
  • Loading branch information
ce-rpf committed Nov 9, 2023
1 parent 3ce4671 commit 442c5e0
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .env.example
Original file line number Diff line number Diff line change
Expand Up @@ -7,4 +7,4 @@ REACT_APP_PLAUSIBLE_DATA_DOMAIN=''
REACT_APP_PLAUSIBLE_SOURCE=''
REACT_APP_SENTRY_DSN=''
REACT_APP_SENTRY_ENV='local'
PUBLIC_URL='http://localhost:3000'
PUBLIC_URL='http://localhost:3010'
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),

### Changed

- Move local development port to avoid projects-ui clash (#736)
- Update design-system-react dependency to publicly available version

## [0.19.4] - 2023-11-08
Expand Down
7 changes: 5 additions & 2 deletions docker-compose.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,14 +17,17 @@ services:
<<: *x-app
command: yarn start
ports:
- "3000:3000"
- "3010:3000"
container_name: react-ui
react-ui-wc:
<<: *x-app
command: yarn start:wc
ports:
- "3001:3001"
- "3011:3001"
container_name: react-ui-wc
secrets:
npmrc:
file: ~/.npmrc
networks:
default:
name: shared-development
1 change: 1 addition & 0 deletions webpack.component.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,7 @@ module.exports = {
contentBase: path.join(__dirname, "public"),
index: "web-component.html",
host: "0.0.0.0",
disableHostCheck: true,
port: 3001,
writeToDisk: true,
},
Expand Down

0 comments on commit 442c5e0

Please sign in to comment.