Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Local development tweaks #736

Merged
merged 9 commits into from Nov 9, 2023
Merged

Local development tweaks #736

merged 9 commits into from Nov 9, 2023

Conversation

ce-rpf
Copy link
Contributor

@ce-rpf ce-rpf commented Nov 9, 2023

Just a couple of small tweaks to make local development easier:

  • disableHostCheck facilitates using the rpfdev.com domain I'm working on (I'll share more details of this once its ready for use!)
  • adding shared network facilitates a local nginx proxy
  • changing port avoids a clash with projects-ui

Copy link

github-actions bot commented Nov 9, 2023

@ce-rpf ce-rpf temporarily deployed to previews/local-dev-tweaks November 9, 2023 11:44 — with GitHub Actions Inactive
Copy link

github-actions bot commented Nov 9, 2023

@loiswells97
Copy link
Contributor

Can we have the main editor site on 3010 too? I think might be clashing with something else as well?

@ce-rpf ce-rpf temporarily deployed to previews/local-dev-tweaks November 9, 2023 11:49 — with GitHub Actions Inactive
@ce-rpf
Copy link
Contributor Author

ce-rpf commented Nov 9, 2023

Main editor now on 3010 :)

Copy link

github-actions bot commented Nov 9, 2023

@ce-rpf ce-rpf temporarily deployed to previews/local-dev-tweaks November 9, 2023 14:03 — with GitHub Actions Inactive
Copy link

github-actions bot commented Nov 9, 2023

CHANGELOG.md Outdated
@@ -31,6 +31,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
- Moved web component custom events from the `editor-wc` element to the `document` (#710)
- Renamed web component custom events to be prefixed with `editor-` (#710)
- Switch props of `WebComponentLoader` from `snake_case` to `camelCase` (#712)
- Move local development port to avoid projects-ui clash (#736)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⛏️ can we move this to the Unreleased section?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦 done, sorry!

@ce-rpf ce-rpf temporarily deployed to previews/local-dev-tweaks November 9, 2023 14:13 — with GitHub Actions Inactive
Copy link

github-actions bot commented Nov 9, 2023

Copy link

github-actions bot commented Nov 9, 2023

Copy link
Contributor

@sra405 sra405 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 finally no more port clashes!!

@ce-rpf ce-rpf merged commit 442c5e0 into main Nov 9, 2023
8 checks passed
@ce-rpf ce-rpf deleted the local-dev-tweaks branch November 9, 2023 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants