New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix MZ spacing problems #190

Closed

3 tasks

loiswells97 opened this issue Sep 15, 2022 · 1 comment · Fixed by #191

Assignees

Contributor

loiswells97 commented Sep 15, 2022

Sort out width issues especially with the motion sensor switch
Make boxes for roll, pitch and yaw wider so they don't go onto the next line
Make the actual astro pi model not so tiny

loiswells97 self-assigned this

Contributor

create-issue-branch bot commented Sep 15, 2022

Branch issues/190-Fix_MZ_spacing_problems created!

create-issue-branch bot pushed a commit that referenced this issue


          Create draft PR for #190

5553e6f

create-issue-branch bot mentioned this issue

Fix MZ spacing problems #191

Merged

loiswells97 closed this as completed in #191

loiswells97 added a commit that referenced this issue


          Fix MZ spacing problems (#191)

29a1adc

# What's Changed?

- Moved the fourth column of the Astro Pi control panel to underneath
- Increased the spacing between the roll, pitch and yaw values 

## Review app


https://staging-editor.raspberrypi.org/branches/issues_190-Fix_MZ_spacing_problems/web-component.html?sense_hat_always_enabled=t

## Screenshots

### Before

<img width="900" alt="Screenshot 2022-09-21 at 15 54 24"
src="https://user-images.githubusercontent.com/88904316/191538317-69592bf4-8042-4b49-8476-d56b5632af1b.png">

### After

<img width="897" alt="Screenshot 2022-09-21 at 15 55 52"
src="https://user-images.githubusercontent.com/88904316/191538493-14471508-965b-4c9a-a9e8-d8c8a7658fa0.png">

## What's not changed?

- Making the web component responsive (would need to be relative to the
width of its container on the host page rather than purely the page
width, maybe using container queries?)

closes #190

Co-authored-by: loiswells97 <loiswells97@users.noreply.github.com>
Co-authored-by: Lois Wells <lois.wells@raspberrypi.org>
Co-authored-by: Patrick Cherry <patch0@users.noreply.github.com>
Co-authored-by: Lois Wells <88904316+loiswells97@users.noreply.github.com>

sHtev pushed a commit that referenced this issue


          Fix MZ spacing problems (#191)

95690c2

# What's Changed?

- Moved the fourth column of the Astro Pi control panel to underneath
- Increased the spacing between the roll, pitch and yaw values 

## Review app


https://staging-editor.raspberrypi.org/branches/issues_190-Fix_MZ_spacing_problems/web-component.html?sense_hat_always_enabled=t

## Screenshots

### Before

<img width="900" alt="Screenshot 2022-09-21 at 15 54 24"
src="https://user-images.githubusercontent.com/88904316/191538317-69592bf4-8042-4b49-8476-d56b5632af1b.png">

### After

<img width="897" alt="Screenshot 2022-09-21 at 15 55 52"
src="https://user-images.githubusercontent.com/88904316/191538493-14471508-965b-4c9a-a9e8-d8c8a7658fa0.png">

## What's not changed?

- Making the web component responsive (would need to be relative to the
width of its container on the host page rather than purely the page
width, maybe using container queries?)

closes #190

Co-authored-by: loiswells97 <loiswells97@users.noreply.github.com>
Co-authored-by: Lois Wells <lois.wells@raspberrypi.org>
Co-authored-by: Patrick Cherry <patch0@users.noreply.github.com>
Co-authored-by: Lois Wells <88904316+loiswells97@users.noreply.github.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment