Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MZ spacing problems #191

Merged
merged 11 commits into from
Sep 22, 2022
Merged

Conversation

create-issue-branch[bot]
Copy link
Contributor

@create-issue-branch create-issue-branch bot commented Sep 15, 2022

What's Changed?

  • Moved the fourth column of the Astro Pi control panel to underneath
  • Increased the spacing between the roll, pitch and yaw values

Review app

https://staging-editor.raspberrypi.org/branches/issues_190-Fix_MZ_spacing_problems/web-component.html?sense_hat_always_enabled=t

Screenshots

Before

Screenshot 2022-09-21 at 15 54 24

After

Screenshot 2022-09-21 at 15 55 52

What's not changed?

  • Making the web component responsive (would need to be relative to the width of its container on the host page rather than purely the page width, maybe using container queries?)

closes #190

@create-issue-branch create-issue-branch bot temporarily deployed to previews/issues/190-Fix_MZ_spacing_problems September 15, 2022 08:57 Inactive
@github-actions
Copy link

@github-actions
Copy link

@github-actions
Copy link

@patch0 patch0 temporarily deployed to previews/issues/190-Fix_MZ_spacing_problems September 16, 2022 17:07 Inactive
@github-actions
Copy link

@loiswells97 loiswells97 temporarily deployed to previews/issues/190-Fix_MZ_spacing_problems September 21, 2022 11:35 Inactive
@github-actions
Copy link

@loiswells97 loiswells97 temporarily deployed to previews/issues/190-Fix_MZ_spacing_problems September 21, 2022 11:40 Inactive
@github-actions
Copy link

@loiswells97 loiswells97 temporarily deployed to previews/issues/190-Fix_MZ_spacing_problems September 21, 2022 12:37 Inactive
@github-actions
Copy link

@loiswells97 loiswells97 temporarily deployed to previews/issues/190-Fix_MZ_spacing_problems September 21, 2022 14:43 Inactive
@github-actions
Copy link

@loiswells97 loiswells97 marked this pull request as ready for review September 21, 2022 14:58
@loiswells97 loiswells97 temporarily deployed to previews/issues/190-Fix_MZ_spacing_problems September 21, 2022 15:10 Inactive
@github-actions
Copy link

@loiswells97 loiswells97 temporarily deployed to previews/issues/190-Fix_MZ_spacing_problems September 21, 2022 15:30 Inactive
@github-actions
Copy link

@github-actions
Copy link

Copy link
Contributor

@patch0 patch0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@loiswells97 loiswells97 merged commit 29a1adc into main Sep 22, 2022
@loiswells97 loiswells97 deleted the issues/190-Fix_MZ_spacing_problems branch September 22, 2022 11:06
sHtev pushed a commit that referenced this pull request Sep 23, 2022
# What's Changed?

- Moved the fourth column of the Astro Pi control panel to underneath
- Increased the spacing between the roll, pitch and yaw values 

## Review app


https://staging-editor.raspberrypi.org/branches/issues_190-Fix_MZ_spacing_problems/web-component.html?sense_hat_always_enabled=t

## Screenshots

### Before

<img width="900" alt="Screenshot 2022-09-21 at 15 54 24"
src="https://user-images.githubusercontent.com/88904316/191538317-69592bf4-8042-4b49-8476-d56b5632af1b.png">

### After

<img width="897" alt="Screenshot 2022-09-21 at 15 55 52"
src="https://user-images.githubusercontent.com/88904316/191538493-14471508-965b-4c9a-a9e8-d8c8a7658fa0.png">

## What's not changed?

- Making the web component responsive (would need to be relative to the
width of its container on the host page rather than purely the page
width, maybe using container queries?)

closes #190

Co-authored-by: loiswells97 <loiswells97@users.noreply.github.com>
Co-authored-by: Lois Wells <lois.wells@raspberrypi.org>
Co-authored-by: Patrick Cherry <patch0@users.noreply.github.com>
Co-authored-by: Lois Wells <88904316+loiswells97@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix MZ spacing problems
2 participants