Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set clickable area for skinny buttons and tabs #288

Closed
maddyjoe opened this issue Dec 2, 2022 · 1 comment · Fixed by #299
Closed

Set clickable area for skinny buttons and tabs #288

maddyjoe opened this issue Dec 2, 2022 · 1 comment · Fixed by #299
Assignees
@IzzySmillie
Labels
accessibility UI/UX

Comments

@maddyjoe
Copy link
Contributor

maddyjoe commented Dec 2, 2022 •
edited
Loading

For the buttons and tabs (which should have been set up in previous stories) but that follow this updated component file
we need to set the area for the interactive area/clickable area to be larger than the border (aka include the padding around the button) for accessibility reasons, to give a large enough minimum hit/touch area.

These skinny components are used -> in the tab sections for input/output, and in the buttons that appear in file panel.
@maddyjoe maddyjoe mentioned this issue Dec 6, 2022
Closed
@IzzySmillie IzzySmillie self-assigned this Dec 14, 2022
@create-issue-branch
Copy link
Contributor

Branch issues/288-Set_clickable_area_for_skinny_buttons_and_tabs created!

create-issue-branch bot pushed a commit that referenced this issue Dec 14, 2022
@IzzySmillie
Create draft PR for #288
31920a3
@create-issue-branch create-issue-branch bot mentioned this issue Dec 14, 2022
Merged
IzzySmillie added a commit that referenced this issue Dec 22, 2022
@create-issue-branch @IzzySmillie
Set clickable area for skinny buttons and tabs (#299)
d6da7fa 
- closes #288





https://user-images.githubusercontent.com/14238047/208932853-20d38fcd-3441-4c95-9a40-707329672e24.mov

Co-authored-by: IzzySmillie <IzzySmillie@users.noreply.github.com>
Co-authored-by: Izzy Smillie <isabelle.smillie@raspberrypi.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@IzzySmillie IzzySmillie

Labels
accessibility UI/UX
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Set clickable area for skinny buttons and tabs RaspberryPiFoundation/editor-ui
2 participants
@IzzySmillie @maddyjoe