Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set clickable area for skinny buttons and tabs #299

Merged
merged 20 commits into from
Dec 22, 2022
Merged

Set clickable area for skinny buttons and tabs #299

merged 20 commits into from
Dec 22, 2022

Conversation

create-issue-branch[bot]
Copy link
Contributor

@create-issue-branch create-issue-branch bot commented Dec 14, 2022 •
edited by IzzySmillie

@create-issue-branch create-issue-branch bot temporarily deployed to previews/issues/288-Set_clickable_area_for_skinny_buttons_and_tabs December 14, 2022 09:26 Inactive
@github-actions
Copy link

@github-actions
Copy link

@IzzySmillie IzzySmillie temporarily deployed to previews/issues/288-Set_clickable_area_for_skinny_buttons_and_tabs December 14, 2022 11:43 — with GitHub Actions Inactive
@github-actions
Copy link

@IzzySmillie IzzySmillie temporarily deployed to previews/issues/288-Set_clickable_area_for_skinny_buttons_and_tabs December 14, 2022 12:10 — with GitHub Actions Inactive
@IzzySmillie IzzySmillie temporarily deployed to previews/issues/288-Set_clickable_area_for_skinny_buttons_and_tabs December 14, 2022 12:34 — with GitHub Actions Inactive
@github-actions
Copy link

@IzzySmillie IzzySmillie temporarily deployed to previews/issues/288-Set_clickable_area_for_skinny_buttons_and_tabs December 21, 2022 12:31 — with GitHub Actions Inactive
@github-actions
Copy link

@IzzySmillie
Checkout button and app scss files from issues/274-Update_button_and_…
c5c454a 
…tab_active_or_inactive_for_both_colour_modes
@IzzySmillie IzzySmillie temporarily deployed to previews/issues/288-Set_clickable_area_for_skinny_buttons_and_tabs December 21, 2022 14:19 — with GitHub Actions Inactive
@IzzySmillie IzzySmillie temporarily deployed to previews/issues/288-Set_clickable_area_for_skinny_buttons_and_tabs December 21, 2022 14:22 — with GitHub Actions Inactive
@github-actions
Copy link

@github-actions
Copy link

@IzzySmillie IzzySmillie temporarily deployed to previews/issues/288-Set_clickable_area_for_skinny_buttons_and_tabs December 21, 2022 14:32 — with GitHub Actions Inactive
@github-actions
Copy link

@IzzySmillie IzzySmillie temporarily deployed to previews/issues/288-Set_clickable_area_for_skinny_buttons_and_tabs December 21, 2022 14:47 — with GitHub Actions Inactive
@github-actions
Copy link

@IzzySmillie IzzySmillie temporarily deployed to previews/issues/288-Set_clickable_area_for_skinny_buttons_and_tabs December 21, 2022 17:39 — with GitHub Actions Inactive
@IzzySmillie IzzySmillie temporarily deployed to previews/issues/288-Set_clickable_area_for_skinny_buttons_and_tabs December 21, 2022 17:40 — with GitHub Actions Inactive
@IzzySmillie IzzySmillie temporarily deployed to previews/issues/288-Set_clickable_area_for_skinny_buttons_and_tabs December 21, 2022 17:40 — with GitHub Actions Inactive
@IzzySmillie IzzySmillie marked this pull request as ready for review December 21, 2022 17:41
@github-actions
Copy link

@github-actions
Copy link

@github-actions
Copy link

@IzzySmillie IzzySmillie temporarily deployed to previews/issues/288-Set_clickable_area_for_skinny_buttons_and_tabs December 22, 2022 09:11 — with GitHub Actions Inactive
@github-actions
Copy link

@IzzySmillie IzzySmillie temporarily deployed to previews/issues/288-Set_clickable_area_for_skinny_buttons_and_tabs December 22, 2022 09:27 — with GitHub Actions Inactive
@github-actions
Copy link

@loiswells97
Copy link
Contributor

I might have missed this, but I think the Add file button is supposed to be skinny as well... So I think we're meant to have the option of skinny buttons as well as skinny tabs

@IzzySmillie
Copy link
Contributor

I might have missed this, but I think the Add file button is supposed to be skinny as well... So I think we're meant to have the option of skinny buttons as well as skinny tabs

The 'Add file' button is a large primary button and then the file list items have all been sorted on the buttons PR. Unless I'm missing a design or misunderstanding something?

@loiswells97
Copy link
Contributor

Hmm okay, I was looking here which has the add file button the same height as the skinny tabs with what looks like a larger clickable area than the actual button

loiswells97
loiswells97 reviewed Dec 22, 2022
View reviewed changes
src/tabs.scss Outdated Show resolved Hide resolved
src/tabs.scss Outdated Show resolved Hide resolved
@github-actions
Copy link

loiswells97
loiswells97 approved these changes Dec 22, 2022
View reviewed changes
Copy link
Contributor

@loiswells97 loiswells97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 👍 🎉

@IzzySmillie IzzySmillie merged commit d6da7fa into main Dec 22, 2022
@IzzySmillie IzzySmillie deleted the issues/288-Set_clickable_area_for_skinny_buttons_and_tabs branch December 22, 2022 11:20
@patch0 patch0 mentioned this pull request Jan 6, 2023
Merged
patch0 added a commit that referenced this pull request Jan 6, 2023
@patch0
Release v0.10.0 (#320)
1153a99 
### Added

- Plausbile event tracking for login, remix, save and code run (#250)
- Message prompting users to login or save if they make non-autosaved
changes (#291)
- Unit tests for the autosave trigger (#291)
- Project not found and access denied modals shown on project loading
error (#298)
- Styling for small buttons (#303)
- Project page header and styling (#314)
- Ability to open and focus files from the left hand file pane (#301)
- Ability to close file tabs (#301)
- Validation to prevent file names containing spaces (#301)

## Changed

- Bump terser from 4.8.0 to 4.8.1 (#143)
- Updated buttons and tabs styling (#296)
- Updated icons (#296)
- Bump engine.io from 6.2.0 to 6.2.1 (#272)
- Increased clickable area for tabs (#299)
- Bump decode-uri-component from 0.2.0 to 0.2.2 (#295)
- File tab bar scrolls rather than wraps (#301)
- Long file names no longer wrap in tab bar (#301)

### Fixed

- Moved `FileMenu` click handler to `MenuItem` for better keyboard
support (#300)
- Touch target size on button to open file context menu (#301)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IzzySmillie IzzySmillie IzzySmillie left review comments

@loiswells97 loiswells97 loiswells97 approved these changes

Assignees

@IzzySmillie IzzySmillie

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Set clickable area for skinny buttons and tabs
2 participants
@loiswells97 @IzzySmillie