Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Project not found or no access rights messaging #297

Closed
loiswells97 opened this issue Dec 12, 2022 · 1 comment · Fixed by #298
Closed

Project not found or no access rights messaging #297

loiswells97 opened this issue Dec 12, 2022 · 1 comment · Fixed by #298
Assignees
@loiswells97

Comments

@loiswells97
Copy link
Contributor

Instead of e.g. a 404 page with messaging, design have recc'd that we use modals, loaded over the top of a blank project, so that the error is contextualised.
Scenarios covered by design (pls split this ticket as needed)

  • logged out - we don't yet know if this is your project
  • logged in - this isn't your project
  • this project doesn't exist (logged in/out = irrelevant)
@loiswells97 loiswells97 self-assigned this Dec 12, 2022
@create-issue-branch
Copy link
Contributor

Branch issues/297-Project_not_found_or_no_access_rights_messaging created!

create-issue-branch bot pushed a commit that referenced this issue Dec 12, 2022
@loiswells97
Create draft PR for #297
55b3f89
@create-issue-branch create-issue-branch bot mentioned this issue Dec 12, 2022
Merged
loiswells97 added a commit that referenced this issue Dec 20, 2022
@create-issue-branch @loiswells97
Project not found or no access rights messaging (#298)
f14b31f 
# What's Changed?

- Added 404 and access denied modals that show when project loading
fails
- Slightly amended the readProject request to include the project type
but needs more discussion around URL structure at a later date

## Screenshots

<img width="807" alt="Screenshot 2022-12-15 at 14 47 43"
src="https://user-images.githubusercontent.com/88904316/207890961-d1611c4e-4a22-4a86-86c9-ba625e809dea.png">
<img width="987" alt="Screenshot 2022-12-15 at 14 45 42"
src="https://user-images.githubusercontent.com/88904316/207891160-568fba87-6b50-48c3-bc65-854824b1e145.png">
<img width="811" alt="Screenshot 2022-12-15 at 14 47 03"
src="https://user-images.githubusercontent.com/88904316/207891167-019c0f76-c999-4baf-8769-e4547a142dd9.png">

closes #297

Co-authored-by: loiswells97 <loiswells97@users.noreply.github.com>
Co-authored-by: Lois Wells <lois.wells@raspberrypi.org>
Co-authored-by: Lois Wells <88904316+loiswells97@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@loiswells97 loiswells97

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Project not found or no access rights messaging RaspberryPiFoundation/editor-ui
1 participant
@loiswells97