Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Project not found or no access rights messaging #298

Merged
merged 16 commits into from
Dec 20, 2022
Merged

Project not found or no access rights messaging #298

merged 16 commits into from
Dec 20, 2022

Conversation

create-issue-branch[bot]
Copy link
Contributor

@create-issue-branch create-issue-branch bot commented Dec 12, 2022 •
edited by loiswells97

What's Changed?

  • Added 404 and access denied modals that show when project loading fails
  • Slightly amended the readProject request to include the project type but needs more discussion around URL structure at a later date

Screenshots

Screenshot 2022-12-15 at 14 47 43

Screenshot 2022-12-15 at 14 45 42

Screenshot 2022-12-15 at 14 47 03

closes #297

@create-issue-branch create-issue-branch bot temporarily deployed to previews/issues/297-Project_not_found_or_no_access_rights_messaging December 12, 2022 10:40 Inactive
@github-actions
Copy link

@github-actions
Copy link

@loiswells97 loiswells97 temporarily deployed to previews/issues/297-Project_not_found_or_no_access_rights_messaging December 12, 2022 14:52 — with GitHub Actions Inactive
@loiswells97 loiswells97 temporarily deployed to previews/issues/297-Project_not_found_or_no_access_rights_messaging December 12, 2022 15:57 — with GitHub Actions Inactive
@loiswells97 loiswells97 temporarily deployed to previews/issues/297-Project_not_found_or_no_access_rights_messaging December 12, 2022 16:23 — with GitHub Actions Inactive
@loiswells97 loiswells97 temporarily deployed to previews/issues/297-Project_not_found_or_no_access_rights_messaging December 12, 2022 16:24 — with GitHub Actions Inactive
@loiswells97 loiswells97 temporarily deployed to previews/issues/297-Project_not_found_or_no_access_rights_messaging December 14, 2022 09:55 — with GitHub Actions Inactive
@loiswells97 loiswells97 temporarily deployed to previews/issues/297-Project_not_found_or_no_access_rights_messaging December 15, 2022 09:53 — with GitHub Actions Inactive
@loiswells97 loiswells97 temporarily deployed to previews/issues/297-Project_not_found_or_no_access_rights_messaging December 15, 2022 11:12 — with GitHub Actions Inactive
@github-actions
Copy link

@loiswells97 loiswells97 temporarily deployed to previews/issues/297-Project_not_found_or_no_access_rights_messaging December 15, 2022 12:41 — with GitHub Actions Inactive
@github-actions
Copy link

@loiswells97 loiswells97 temporarily deployed to previews/issues/297-Project_not_found_or_no_access_rights_messaging December 15, 2022 12:55 — with GitHub Actions Inactive
@github-actions
Copy link

@loiswells97 loiswells97 temporarily deployed to previews/issues/297-Project_not_found_or_no_access_rights_messaging December 15, 2022 13:04 — with GitHub Actions Inactive
@github-actions
Copy link

@loiswells97 loiswells97 marked this pull request as ready for review December 15, 2022 15:01
@loiswells97 loiswells97 temporarily deployed to previews/issues/297-Project_not_found_or_no_access_rights_messaging December 19, 2022 16:17 — with GitHub Actions Inactive
@github-actions
Copy link

@loiswells97 loiswells97 temporarily deployed to previews/issues/297-Project_not_found_or_no_access_rights_messaging December 19, 2022 16:48 — with GitHub Actions Inactive
@github-actions
Copy link

@github-actions
Copy link

@loiswells97 loiswells97 merged commit f14b31f into main Dec 20, 2022
@loiswells97 loiswells97 deleted the issues/297-Project_not_found_or_no_access_rights_messaging branch December 20, 2022 09:53
@patch0 patch0 mentioned this pull request Jan 6, 2023
Merged
patch0 added a commit that referenced this pull request Jan 6, 2023
@patch0
Release v0.10.0 (#320)
1153a99 
### Added

- Plausbile event tracking for login, remix, save and code run (#250)
- Message prompting users to login or save if they make non-autosaved
changes (#291)
- Unit tests for the autosave trigger (#291)
- Project not found and access denied modals shown on project loading
error (#298)
- Styling for small buttons (#303)
- Project page header and styling (#314)
- Ability to open and focus files from the left hand file pane (#301)
- Ability to close file tabs (#301)
- Validation to prevent file names containing spaces (#301)

## Changed

- Bump terser from 4.8.0 to 4.8.1 (#143)
- Updated buttons and tabs styling (#296)
- Updated icons (#296)
- Bump engine.io from 6.2.0 to 6.2.1 (#272)
- Increased clickable area for tabs (#299)
- Bump decode-uri-component from 0.2.0 to 0.2.2 (#295)
- File tab bar scrolls rather than wraps (#301)
- Long file names no longer wrap in tab bar (#301)

### Fixed

- Moved `FileMenu` click handler to `MenuItem` for better keyboard
support (#300)
- Touch target size on button to open file context menu (#301)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patch0 patch0 patch0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Project not found or no access rights messaging
2 participants
@patch0 @loiswells97