Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integration: Margin between elements should be 24px (rem eqv.) #841

Closed
maxelkins opened this issue Dec 19, 2023 · 1 comment · Fixed by #856
Closed

Integration: Margin between elements should be 24px (rem eqv.) #841

maxelkins opened this issue Dec 19, 2023 · 1 comment · Fixed by #856
Assignees
@loiswells97
Labels
QA
Milestone
Editor Integratio...

Comments

@maxelkins
Copy link
Contributor

maxelkins commented Dec 19, 2023 •
edited

Gap between all the different instruction elements is currently too small (16px) should be 24px (rem equivalent)

For example:
Image

Design reference:

Image
@maxelkins maxelkins added the QA label Dec 19, 2023
@maxelkins maxelkins changed the title Margin between elements should be 24px (rem eqv.) Integration: Margin between elements should be 24px (rem eqv.) Dec 19, 2023
@sra405 sra405 added this to the Editor Integration (beta) milestone Dec 20, 2023
@loiswells97 loiswells97 self-assigned this Dec 21, 2023
@create-issue-branch Create Issue Branch
Copy link
Contributor

Branch issues/841-Integration_Margin_between_elements_should_be_24px_rem_eqv created!

create-issue-branch bot added a commit that referenced this issue Dec 21, 2023
@create-issue-branch
Create draft PR for #841
3601d42
@create-issue-branch create-issue-branch bot mentioned this issue Dec 21, 2023
Merged
loiswells97 added a commit that referenced this issue Jan 2, 2024
@create-issue-branch @loiswells97 @magdalenajadach
Integration: Margin between elements should be 24px (rem eqv.) (#856)
9b28ba6 
closes #841

---------

Co-authored-by: create-issue-branch[bot] <53036503+create-issue-branch[bot]@users.noreply.github.com>
Co-authored-by: Lois Wells <lois.wells@raspberrypi.org>
Co-authored-by: Lois Wells <88904316+loiswells97@users.noreply.github.com>
Co-authored-by: MagdalenaJadach <magdalena@raspberrypi.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@loiswells97 loiswells97

Labels
QA
Projects
None yet
Milestone
Editor Integration (beta)
Development

Successfully merging a pull request may close this issue.

Integration: Margin between elements should be 24px (rem eqv.) RaspberryPiFoundation/editor-ui
3 participants
@maxelkins @sra405 @loiswells97