Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Login flow tests #211

Merged
merged 13 commits into from
Oct 6, 2022
Merged

Login flow tests #211

merged 13 commits into from
Oct 6, 2022

Conversation

loiswells97
Copy link
Contributor

@loiswells97 loiswells97 commented Oct 3, 2022

What's Changed?

  • Slightly refactored Login button component to access user from the store rather than having this data passed as a prop
  • Refactored and added more tests for Login button component
  • Added tests for the useProject hook
  • Upgraded to Jest 29

closes #208

@loiswells97 loiswells97 temporarily deployed to previews/login-flow-tests October 3, 2022 10:27 Inactive
@loiswells97 loiswells97 marked this pull request as draft October 3, 2022 10:34
@loiswells97 loiswells97 temporarily deployed to previews/login-flow-tests October 3, 2022 15:55 Inactive
@github-actions
Copy link

github-actions bot commented Oct 3, 2022

@loiswells97 loiswells97 temporarily deployed to previews/login-flow-tests October 3, 2022 16:16 Inactive
@github-actions
Copy link

github-actions bot commented Oct 3, 2022

@loiswells97 loiswells97 temporarily deployed to previews/login-flow-tests October 3, 2022 16:27 Inactive
@github-actions
Copy link

github-actions bot commented Oct 3, 2022

@loiswells97 loiswells97 temporarily deployed to previews/login-flow-tests October 4, 2022 15:09 Inactive
@github-actions
Copy link

github-actions bot commented Oct 4, 2022

@loiswells97 loiswells97 temporarily deployed to previews/login-flow-tests October 4, 2022 16:02 Inactive
@loiswells97 loiswells97 temporarily deployed to previews/login-flow-tests October 5, 2022 09:39 Inactive
@loiswells97 loiswells97 temporarily deployed to previews/211/merge October 5, 2022 09:39 Inactive
@loiswells97 loiswells97 temporarily deployed to previews/211/merge October 5, 2022 14:02 Inactive
@loiswells97 loiswells97 temporarily deployed to previews/login-flow-tests October 5, 2022 14:02 Inactive
@loiswells97 loiswells97 temporarily deployed to previews/211/merge October 6, 2022 09:42 Inactive
@loiswells97 loiswells97 temporarily deployed to previews/login-flow-tests October 6, 2022 09:42 Inactive
@github-actions
Copy link

github-actions bot commented Oct 6, 2022

@loiswells97 loiswells97 temporarily deployed to previews/211/merge October 6, 2022 11:36 Inactive
@loiswells97 loiswells97 temporarily deployed to previews/211/merge October 6, 2022 11:40 Inactive
Copy link
Contributor

@patch0 patch0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@loiswells97 loiswells97 merged commit c143e44 into main Oct 6, 2022
@loiswells97 loiswells97 deleted the login-flow-tests branch October 6, 2022 14:39
@patch0 patch0 mentioned this pull request Oct 21, 2022
loiswells97 pushed a commit that referenced this pull request Oct 21, 2022
### Added

- Github action for checking if changelog updated (#189)
- The web component `runCompleted` event now returns `duration: null` if
the host page's tab loses focus during the code run (#192)
- Global nav on editor site with link to `raspberrypi.org` and account
menu (#195)
- Footer on editor site with links to Privacy, Cookies, Accessibility
and Safeguarding policies (#200)
- Cookie banner on the editor site (#206) but not in the embedded viewer
(#231)
- Unit tests for login button and 'useProject' hook (#211)
- Script for Google Tag Manager to be used on the standalone editor site
(#225)
- Indentation markers in the editor (#237)
- Ability to switch between split and tabbed output views on the editor
site and in the web component (#234)

### Changed

- Upgraded to Jest 29 (#211)
- Updated Editor site title and logo (#220)
- Updated Codemirror and related dependencies to their latest versions
(#221)
- Update build process to strip non-alphanumeric characters from the
branch name (#222)

### Fixed

- Styling of Astro Pi orientation reset button on editor site (#202)
- Updated text output font to display emojis correctly (#221)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add login flow tests to make it easier for us to test user journeys & behaviours
2 participants