Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sanitizing branch to strip out non alphanumeric chars #222

Merged
merged 18 commits into from
Oct 13, 2022

Conversation

patch0
Copy link
Contributor

@patch0 patch0 commented Oct 6, 2022

Refactor build jobs to ensure branch names are sanitized of any non-alphanumeric characters

@patch0 patch0 self-assigned this Oct 6, 2022
@patch0 patch0 temporarily deployed to previews/222/merge October 6, 2022 16:40 Inactive
@github-actions
Copy link

github-actions bot commented Oct 6, 2022

@github-actions
Copy link

github-actions bot commented Oct 6, 2022

@github-actions
Copy link

github-actions bot commented Oct 6, 2022

@github-actions
Copy link

github-actions bot commented Oct 7, 2022

@github-actions
Copy link

github-actions bot commented Oct 7, 2022

@github-actions
Copy link

github-actions bot commented Oct 7, 2022

@github-actions
Copy link

@patch0 patch0 marked this pull request as ready for review October 13, 2022 10:32
@github-actions
Copy link

Copy link
Contributor

@loiswells97 loiswells97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 😱

@patch0 patch0 merged commit 09b665b into main Oct 13, 2022
@patch0 patch0 deleted the fix/safe/😱/branch&name branch October 13, 2022 14:35
@patch0 patch0 mentioned this pull request Oct 21, 2022
loiswells97 pushed a commit that referenced this pull request Oct 21, 2022
### Added

- Github action for checking if changelog updated (#189)
- The web component `runCompleted` event now returns `duration: null` if
the host page's tab loses focus during the code run (#192)
- Global nav on editor site with link to `raspberrypi.org` and account
menu (#195)
- Footer on editor site with links to Privacy, Cookies, Accessibility
and Safeguarding policies (#200)
- Cookie banner on the editor site (#206) but not in the embedded viewer
(#231)
- Unit tests for login button and 'useProject' hook (#211)
- Script for Google Tag Manager to be used on the standalone editor site
(#225)
- Indentation markers in the editor (#237)
- Ability to switch between split and tabbed output views on the editor
site and in the web component (#234)

### Changed

- Upgraded to Jest 29 (#211)
- Updated Editor site title and logo (#220)
- Updated Codemirror and related dependencies to their latest versions
(#221)
- Update build process to strip non-alphanumeric characters from the
branch name (#222)

### Fixed

- Styling of Astro Pi orientation reset button on editor site (#202)
- Updated text output font to display emojis correctly (#221)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants