Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify when an error is showing in a non-focused file #239

Merged
merged 5 commits into from
Nov 4, 2022
Merged

Clarify when an error is showing in a non-focused file #239

merged 5 commits into from
Nov 4, 2022

Conversation

create-issue-branch[bot]
Copy link
Contributor

@create-issue-branch create-issue-branch bot commented Oct 20, 2022 •
edited by loiswells97
Loading

What's Changed?

  • Added the filename to any errors shown in the editor that are surfaced fromskulpt

Things to note

  • The errors from skulpt give the filename in the traceback for main.py as <stdin>.py.
  • Filenames other than for main are given with a prepended ./ in skulpt errors which has been removed since we are not implementing a file structure (for now) so could be confusing for users if the filename in the error does not match the name of their file exactly.

Screenshots

Screenshot 2022-10-20 at 11 34 03

Screenshot 2022-10-20 at 11 34 37

closes #214

@create-issue-branch create-issue-branch bot temporarily deployed to previews/issues/214-Clarify_when_an_error_is_showing_in_a_non-focused_file October 20, 2022 09:43 Inactive
@github-actions
Copy link

@github-actions
Copy link

@loiswells97 loiswells97 temporarily deployed to previews/issues/214-Clarify_when_an_error_is_showing_in_a_non-focused_file October 20, 2022 10:18 Inactive
@loiswells97 loiswells97 marked this pull request as ready for review October 20, 2022 10:19
@github-actions
Copy link

patch0
patch0 reviewed Oct 21, 2022
View reviewed changes
Copy link
Contributor

@patch0 patch0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could do with a test, perhaps?

@loiswells97 loiswells97 temporarily deployed to previews/issues/214-Clarify_when_an_error_is_showing_in_a_non-focused_file October 21, 2022 16:30 Inactive
@github-actions
Copy link

@sHtev sHtev temporarily deployed to previews/issues/214-Clarify_when_an_error_is_showing_in_a_non-focused_file October 25, 2022 09:41 Inactive
@github-actions
Copy link

@loiswells97 loiswells97 temporarily deployed to previews/issues/214-Clarify_when_an_error_is_showing_in_a_non-focused_file November 4, 2022 15:34 Inactive
@github-actions
Copy link

github-actions bot commented Nov 4, 2022

@sHtev sHtev merged commit 93afa9a into main Nov 4, 2022
@sHtev sHtev deleted the issues/214-Clarify_when_an_error_is_showing_in_a_non-focused_file branch November 4, 2022 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patch0 patch0 patch0 left review comments

@sHtev sHtev sHtev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clarify when an error is showing in a non-focused file
3 participants
@patch0 @sHtev @loiswells97