Fixes Issue #7 by adding new settings field to network admin settings…

[sanghviharshit]

… section

Allows super admin to choose if the settings can be overridden by site admins on individual sites. If not allowed, all the sites in the multisite must use the network settings, otherwise all the admins can choose their own settings for their own sites. Compatible with single site installation as well

[RavanH]

Great addition! Will review and merge soon...

[RavanH]

All looking good. I suppose you tested?

I see only one problem at least for one user. The reason I created the option for Super Admin to override settings per sub-site, is by request of a teacher running a multisite for the children on his school to create a new site per project. The children (being under-age) would not be allowed to create WP.com accounts so the teacher (Super Admin) would need to switch the dev mode option on but only on those sites managed by the children, but not other sites. He would not want to allow site admins to override because these are also school children, only Super Admins.

Now with your new option, I suppose (but have not verified) that if Site Admin is not allowed to override, it's also no longer possible for Super Admin to override?

[sanghviharshit]

Yes, it has been tested in our multisite environment.

The setting field for subsite-override is inspired by Jetpack itself. Check the Jetpack settings from network dashboard when Jetpack is network activated.

So yes, this will cause issue for the one user that you mentioned. But in my opinion, this plugin should at least have this setting for allowing site admins to manage the modules.

To take care of the user that you mentioned, there needs to be an extra settings field that says, "Allow super administrators to manage settings for Jetpack Module Control on individual sites." and with this if the setting for site admins is not enabled, should only allow super admins to manage individual site settings.

What do you think?

[sanghviharshit]

Also, I suppose you can make it a default behavior for super admins to be able to override subsites settings, but we have a huge multisite with a large number of super admins and I would not want any of them to change these settings by mistake while on subsite settings page and certainly not enable wordpress.com connection because it will allow Single Sign On from wordpress.com on the subsite and through that allow access to other subsites in the multisite. It becomes difficult to keep track of this when you have thousands of sites.

[RavanH]

But in my opinion, this plugin should at least have this setting for allowing site admins to manage the modules.

I totally agree, it was on the todo list. Your solution is great.

Also, I suppose you can make it a default behavior for super admins to be able to override subsites settings

That was my first thought, as it's also the current behaviour of the plugin. But your argument for multisites with multiple Super Admins that can make mistakes is a valid one. I'll need to work on a second option for Super Admins override before release on WP.org then...

[sanghviharshit]

Thanks @RavanH will wait for the update on .org. By the way my username on .org is harshit_ps in case you would like to mention that somewhere ;)

[RavanH]

Will do and thanks again @sanghviharshit :)