Fix mining bug - lockup in CreateNewBlock loop #1184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This bug was discovered in Dec-2021 when two blocks were mined within one second. Pool operators locked up and required restarting. It happened because when CheckTxInputs finds a double spend, ConnectBlock fails but didn't mark the bad txn to be flushed from the mempool.
HyperPeek
approved these changes
Feb 22, 2022
|
I re-opened this PR. It was closed unintentionally automatically by github as a side-effect of some cleanup I did on my local repo of the code fork in my personal github account.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bug was discovered in Dec-2021 on mainnet when two blocks were mined within one second. Pool operators locked up and required restarting.
It happened because when CheckTxInputs finds a double spend, ConnectBlock fails but does not mark the bad transaction to be flushed from the mempool.
It is described in detail in Issue #1183 which this PR fixes.
Thanks go to Jeremy for help with this bug.