Add P2SH support for tagging addresses #1196
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was the bug
If you try to tag a P2SH address with a Qualifier, the tag lands instead on the P2PKH address whose HASH160 is the same as the hash of the redeem script of the intended P2SH address. In English: you can't tag P2SH addresses because the tag goes to a different address.This fix was written and tested via regtest. If this was to go live without the proper bip9 activation the chain could suffer a fork. Would probably be a good idea to wrap these changes with the P2SH bip9 if it hasn't gone to mainnet yet.
Feel free to cherry-pick this commit, add the proper bip9 activation code before releasing to testnet / mainnet.