Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update develop with enforced value fixes #794

Merged
merged 14 commits into from
Jul 8, 2020

Conversation

blondfrogs
Copy link
Contributor

@blondfrogs blondfrogs commented Jul 6, 2020

Code Added by developers:
@akshaynexus - 8c1fb71
@blondfrogs - 62c30f9, 905952c, 787d4c0, 9c8fbc0, 8141607, c455cfc, 185a052, 09578af, 627a6f0, 405e1ee, ae65a29, e889065

Closes #795

src/chainparams.cpp Outdated Show resolved Hide resolved
src/chainparams.cpp Outdated Show resolved Hide resolved
src/chainparams.cpp Outdated Show resolved Hide resolved
src/rpc/blockchain.cpp Outdated Show resolved Hide resolved
Copy link
Contributor

@spyder46n2 spyder46n2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, I liked running throught the code review via Zoom.

Copy link
Collaborator

@TronBlack TronBlack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd feel more comfortable if these were
#define CONSTANTS

bool fCheckBlock = true;
bool fCheckDuplicates = true;

@blondfrogs blondfrogs merged commit 71520c5 into RavenProject:develop Jul 8, 2020
@blondfrogs blondfrogs deleted the master_updated branch August 26, 2022 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants