Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The moving_sphere class is mostly redundant with sphere, and lacks UV coordinates #1125

Closed
hollasch opened this issue May 11, 2023 · 0 comments
Closed

The moving_sphere class is mostly redundant with sphere, and lacks UV coordinates #1125

hollasch opened this issue May 11, 2023 · 0 comments
Assignees
@hollasch
Milestone
v4.0.0

Comments

@hollasch
Copy link
Collaborator

It should be a simple matter of adding a second constructor to the sphere class to add the ability to be a moving sphere.
@hollasch hollasch added this to the v4.0.0 milestone May 11, 2023
@hollasch hollasch self-assigned this May 11, 2023
hollasch added a commit that referenced this issue May 11, 2023
@hollasch
Update the sphere class to allow movement
f0cf5b1 
This change deprecates the moving_sphere class, and instead extends the
existing sphere class to include this functionality.

Note that in TheRestOfYourLife, the PDF functions ignore the moving
aspect, and assume a static sphere (which preserves existing behavior).

See issue #1125
@hollasch hollasch mentioned this issue May 11, 2023
Closed
hollasch added a commit that referenced this issue Jun 6, 2023
@hollasch
Update books with new moving-capable sphere class
7b55405 
Resolves #1125
hollasch added a commit that referenced this issue Jun 6, 2023
@hollasch
Update books with new moving-capable sphere class
250c52e 
Resolves #1125
hollasch added a commit that referenced this issue Jun 7, 2023
@hollasch
Update books with new moving-capable sphere class
1fe2918 
Resolves #1125
@hollasch hollasch closed this as completed Jun 7, 2023
trevordblack pushed a commit that referenced this issue Jun 8, 2023
@hollasch @trevordblack
Update books with new moving-capable sphere class
5082508 
Resolves #1125
trevordblack pushed a commit that referenced this issue Jun 25, 2023
@hollasch @trevordblack
Update books with new moving-capable sphere class
d3e54dd 
Resolves #1125
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hollasch hollasch

Labels
None yet
Projects
None yet
Milestone
v4.0.0
Development

No branches or pull requests
1 participant
@hollasch