Update the sphere class to allow movement #1128
Conversation
This change deprecates the moving_sphere class, and instead extends the existing sphere class to include this functionality. Note that in TheRestOfYourLife, the PDF functions ignore the moving aspect, and assume a static sphere (which preserves existing behavior). See issue #1125
There was a problem hiding this comment.
I think I'm okay with this.
It's not a complete refactoring with full support for time and SRTs.
But, it's not a massive increase in understanding for the user,
AND it's just objectively better than what exists at the moment.
I think the only potential gotcha is that previously a "moving sphere" represented a completely different geometric object than a regular sphere. Here, there is no true distinction between the two. A "moving sphere" is just a sphere.
This is definitely a change in mental model. I think it's an improvement. But it's a change in mental model and I might need a few days to simmer to make sure.
Feel free to ship, but I may come back with concerns
|
Final work is complete in the |
This change deprecates the moving_sphere class, and instead extends the existing sphere class to include this functionality.
Note that in TheRestOfYourLife, the PDF functions ignore the moving aspect, and assume a static sphere (which preserves existing behavior).
See issue #1125
This is the code portion only, shared for feedback.