Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Listing 3.40: Update code listing change highlighting #1317

Closed
hollasch opened this issue Oct 27, 2023 · 1 comment
Closed

Listing 3.40: Update code listing change highlighting #1317

hollasch opened this issue Oct 27, 2023 · 1 comment
Assignees
@hollasch
Labels
book 3: Your Life level: patch
Milestone
v4.0.0

Comments

@hollasch
Copy link
Collaborator

Benny Tsang writes:

  • (Book 3) Listing 40: ray_color's function signature should also be highlighted since we have added hittable lights. Also light_ptr in the hittable_pdf constructor should be lights.
@hollasch hollasch added this to the v4.0.0 milestone Oct 27, 2023
@hollasch hollasch self-assigned this Oct 27, 2023
@hollasch hollasch assigned rupsis and unassigned hollasch Feb 10, 2024
@hollasch hollasch changed the title Listing 3.40 / Update code listing change highlighting Listing 3.40: Update code listing change highlighting Apr 19, 2024
@hollasch hollasch assigned hollasch and unassigned rupsis Apr 21, 2024
hollasch added a commit that referenced this issue Apr 23, 2024
@hollasch
Updates from book 3 complete progression
77471af 
Also includes some minor fixes.

Note that this shows the current state of some buggy renders, which
render the entire scene as black, except for the single square light
source.

Resolves #988
Resolves #1317
@hollasch hollasch mentioned this issue Apr 23, 2024
Merged
hollasch added a commit that referenced this issue Apr 23, 2024
@hollasch
Updates from book 3 complete progression
07b339c 
Also includes some minor fixes.

Note that this shows the current state of some buggy renders, which
render the entire scene as black, except for the single square light
source.

Resolves #988
Resolves #1317
@hollasch
Copy link
Collaborator Author

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hollasch hollasch

Labels
book 3: Your Life level: patch
Projects
None yet
Milestone
v4.0.0
Development

No branches or pull requests
2 participants
@hollasch @rupsis